2015-11-03 01:49:56

by Dmitry Torokhov

Subject: Re: [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions

On Fri, Oct 30, 2015 at 07:41:23PM -0500, Michael Welling wrote:
> This patch separates the SPI functionality from core functionality
> that overlaps with the tsc2004.
>
> Prepares kernel for new tsc2004 driver without much redundant code.
>
> Signed-off-by: Michael Welling <[email protected]>
> ---
> drivers/input/touchscreen/Kconfig | 4 +
> drivers/input/touchscreen/Makefile | 1 +
> drivers/input/touchscreen/tsc2005.c | 709 +--------------------
> .../touchscreen/{tsc2005.c => tsc200x-core.c} | 226 ++-----
> drivers/input/touchscreen/tsc200x-core.h | 78 +++
> 5 files changed, 162 insertions(+), 856 deletions(-)
> copy drivers/input/touchscreen/{tsc2005.c => tsc200x-core.c} (72%)
> create mode 100644 drivers/input/touchscreen/tsc200x-core.h

This was giving me:

Kernel: arch/x86/boot/bzImage is ready (#1451)
MODPOST 1447 modules
ERROR: "tsc200x_regmap_config" [drivers/input/touchscreen/tsc2005.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

I'll fix it up locally by exporting the symbol.

Thanks.

--
Dmitry

2015-11-03 15:49:14

by Michael Welling

Subject: Re: [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions

On Mon, Nov 02, 2015 at 05:49:46PM -0800, Dmitry Torokhov wrote:
> On Fri, Oct 30, 2015 at 07:41:23PM -0500, Michael Welling wrote:
> > This patch separates the SPI functionality from core functionality
> > that overlaps with the tsc2004.
> >
> > Prepares kernel for new tsc2004 driver without much redundant code.
> >
> > Signed-off-by: Michael Welling <[email protected]>
> > ---
> > drivers/input/touchscreen/Kconfig | 4 +
> > drivers/input/touchscreen/Makefile | 1 +
> > drivers/input/touchscreen/tsc2005.c | 709 +--------------------
> > .../touchscreen/{tsc2005.c => tsc200x-core.c} | 226 ++-----
> > drivers/input/touchscreen/tsc200x-core.h | 78 +++
> > 5 files changed, 162 insertions(+), 856 deletions(-)
> > copy drivers/input/touchscreen/{tsc2005.c => tsc200x-core.c} (72%)
> > create mode 100644 drivers/input/touchscreen/tsc200x-core.h
>
> This was giving me:
>
> Kernel: arch/x86/boot/bzImage is ready (#1451)
> MODPOST 1447 modules
> ERROR: "tsc200x_regmap_config" [drivers/input/touchscreen/tsc2005.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> I'll fix it up locally by exporting the symbol.
>
> Thanks.

Ooops. I guess that I need to check more thoroughly the different configs.

Thanks for your help.

>
> --
> Dmitry