2015-11-05 09:27:01

by Corentin Labbe

Subject: [PATCH] net: stmmac: fix double-initialization of phy_iface

The variable phy_iface is double-initialized to itself.
This patch remove that.

Reported-by: coverity (CID 1271141)
Signed-off-by: LABBE Corentin <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 11baa4b..0cd3ecf 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -354,7 +354,7 @@ static int gmac_clk_init(struct rk_priv_data *bsp_priv)

static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable)
{
- int phy_iface = phy_iface = bsp_priv->phy_iface;
+ int phy_iface = bsp_priv->phy_iface;

if (enable) {
if (!bsp_priv->clk_enabled) {
--
2.4.10

2015-11-05 19:09:55

by David Miller

Subject: Re: [PATCH] net: stmmac: fix double-initialization of phy_iface

From: LABBE Corentin <[email protected]>
Date: Thu, 5 Nov 2015 10:26:46 +0100

> The variable phy_iface is double-initialized to itself.
> This patch remove that.
>
> Reported-by: coverity (CID 1271141)
> Signed-off-by: LABBE Corentin <[email protected]>

Applied.