Changes since v1:
* include module.h in wm8994_regmap
When compiled as a module we get a tainted kernel because of the lack
of the module information and the following errors. Add details to
fix the issue when wm8994_irq/wm8994_regmap are modular.
wm8994_irq: module license 'unspecified' taints kernel.
wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
wm8994_irq: Unknown symbol regmap_write (err 0)
wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
wm8994_irq: Unknown symbol irq_modify_status (err 0)
wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
wm8994_irq: Unknown symbol handle_nested_irq (err 0)
wm8994_irq: Unknown symbol __irq_domain_add (err 0)
wm8994_irq: Unknown symbol irq_create_mapping (err 0)
wm8994_irq: Unknown symbol gpio_to_desc (err 0)
wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
wm8994_regmap: module license 'unspecified' taints kernel.
Cc: <[email protected]>
Signed-off-by: Peter Robinson <[email protected]>
---
drivers/mfd/wm8994-irq.c | 5 +++++
drivers/mfd/wm8994-regmap.c | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/drivers/mfd/wm8994-irq.c b/drivers/mfd/wm8994-irq.c
index 18710f3..5538521 100644
--- a/drivers/mfd/wm8994-irq.c
+++ b/drivers/mfd/wm8994-irq.c
@@ -262,3 +262,8 @@ void wm8994_irq_exit(struct wm8994 *wm8994)
regmap_del_irq_chip(wm8994->irq, wm8994->irq_data);
}
EXPORT_SYMBOL(wm8994_irq_exit);
+
+MODULE_DESCRIPTION("WM8994 interrupt controller");
+MODULE_AUTHOR("Mark Brown <[email protected]>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-irq");
diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c
index c56b160..d088185 100644
--- a/drivers/mfd/wm8994-regmap.c
+++ b/drivers/mfd/wm8994-regmap.c
@@ -14,6 +14,7 @@
#include <linux/mfd/wm8994/core.h>
#include <linux/mfd/wm8994/registers.h>
+#include <linux/module.h>
#include <linux/regmap.h>
#include <linux/device.h>
@@ -1289,3 +1290,8 @@ struct regmap_config wm8994_base_regmap_config = {
.val_bits = 16,
};
EXPORT_SYMBOL(wm8994_base_regmap_config);
+
+MODULE_DESCRIPTION("WM8994 Register mapping data");
+MODULE_AUTHOR("Mark Brown <[email protected]>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-regmap");
--
2.5.0
On Sat, Nov 07, 2015 at 04:25:39PM +0000, Peter Robinson wrote:
> When compiled as a module we get a tainted kernel because of the lack
> of the module information and the following errors. Add details to
> fix the issue when wm8994_irq/wm8994_regmap are modular.
>
> wm8994_irq: module license 'unspecified' taints kernel.
>
> wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
> wm8994_irq: Unknown symbol regmap_write (err 0)
> wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
> wm8994_irq: Unknown symbol irq_modify_status (err 0)
> wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
> wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
> wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
> wm8994_irq: Unknown symbol handle_nested_irq (err 0)
> wm8994_irq: Unknown symbol __irq_domain_add (err 0)
> wm8994_irq: Unknown symbol irq_create_mapping (err 0)
> wm8994_irq: Unknown symbol gpio_to_desc (err 0)
> wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
> wm8994_regmap: module license 'unspecified' taints kernel.
>
> Cc: <[email protected]>
> Signed-off-by: Peter Robinson <[email protected]>
> ---
This looks like the intention was for 8994 to be a single module
can you try the following and see if that also fixes your issue.
Thanks,
Charles
>From ba8cea5e6193c501070553f2f78d1ac59aae252d Mon Sep 17 00:00:00 2001
From: Charles Keepax <[email protected]>
Date: Tue, 10 Nov 2015 10:06:29 +0000
Subject: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module
Signed-off-by: Charles Keepax <[email protected]>
---
drivers/mfd/Makefile | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index ef09bf1..b9c229d 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -63,7 +63,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o
wm8350-objs += wm8350-irq.o
obj-$(CONFIG_MFD_WM8350) += wm8350.o
obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o
-obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o
+wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o
+obj-$(CONFIG_MFD_WM8994) += wm8994.o
obj-$(CONFIG_TPS6105X) += tps6105x.o
obj-$(CONFIG_TPS65010) += tps65010.o
--
1.7.2.5