2015-11-17 20:01:36

by Bogicevic Sasa

Subject: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages

This fixes all "Comparison to NULL could be written like..."
messages from checkpatch.pl

Signed-off-by: Bogicevic Sasa <[email protected]>
---
drivers/staging/wilc1000/coreconfigurator.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index fd7240c..a31ac55 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -434,7 +434,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)

/* Get DTIM Period */
pu8TimElm = get_tim_elm(pu8msa, u16RxLen + FCS_LEN, u8index);
- if (pu8TimElm != NULL)
+ if (!pu8TimElm)
pstrNetworkInfo->u8DtimPeriod = pu8TimElm[3];
pu8IEs = &pu8msa[MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN + CAP_INFO_LEN];
u16IEsLen = u16RxLen - (MAC_HDR_LEN + TIME_STAMP_LEN + BEACON_INTERVAL_LEN + CAP_INFO_LEN);
@@ -468,8 +468,8 @@ s32 DeallocateNetworkInfo(tstrNetworkInfo *pstrNetworkInfo)
{
s32 s32Error = 0;

- if (pstrNetworkInfo != NULL) {
- if (pstrNetworkInfo->pu8IEs != NULL) {
+ if (!pstrNetworkInfo) {
+ if (!pstrNetworkInfo->pu8IEs) {
kfree(pstrNetworkInfo->pu8IEs);
pstrNetworkInfo->pu8IEs = NULL;
} else {
@@ -553,8 +553,8 @@ s32 DeallocateAssocRespInfo(tstrConnectRespInfo *pstrConnectRespInfo)
{
s32 s32Error = 0;

- if (pstrConnectRespInfo != NULL) {
- if (pstrConnectRespInfo->pu8RespIEs != NULL) {
+ if (!pstrConnectRespInfo) {
+ if (!pstrConnectRespInfo->pu8RespIEs) {
kfree(pstrConnectRespInfo->pu8RespIEs);
pstrConnectRespInfo->pu8RespIEs = NULL;
} else {
--
2.1.4

2015-11-18 06:19:42

by Sudip Mukherjee

Subject: Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages

On Tue, Nov 17, 2015 at 09:01:28PM +0100, Bogicevic Sasa wrote:
> This fixes all "Comparison to NULL could be written like..."
> messages from checkpatch.pl
>
> Signed-off-by: Bogicevic Sasa <[email protected]>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index fd7240c..a31ac55 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -434,7 +434,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
>
> /* Get DTIM Period */
> pu8TimElm = get_tim_elm(pu8msa, u16RxLen + FCS_LEN, u8index);
> - if (pu8TimElm != NULL)
> + if (!pu8TimElm)

You are now checking for - if (pu8TimElm == NULL)
It should actually be: if (pu8TimElm)

regards
sudip

2015-11-18 11:30:37

by Bogicevic Sasa

Subject: Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages

On 11/18, Sudip Mukherjee wrote:
>On Tue, Nov 17, 2015 at 09:01:28PM +0100, Bogicevic Sasa wrote:
>> This fixes all "Comparison to NULL could be written like..."
>> messages from checkpatch.pl
>>
>> Signed-off-by: Bogicevic Sasa <[email protected]>
>> ---
>> drivers/staging/wilc1000/coreconfigurator.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
>> index fd7240c..a31ac55 100644
>> --- a/drivers/staging/wilc1000/coreconfigurator.c
>> +++ b/drivers/staging/wilc1000/coreconfigurator.c
>> @@ -434,7 +434,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
>>
>> /* Get DTIM Period */
>> pu8TimElm = get_tim_elm(pu8msa, u16RxLen + FCS_LEN, u8index);
>> - if (pu8TimElm != NULL)
>> + if (!pu8TimElm)
>
>You are now checking for - if (pu8TimElm == NULL)
>It should actually be: if (pu8TimElm)
>
>regards
>sudip
Right, so stuped, Ill resend it