2015-11-19 15:41:19

by Lukas Wunner

Subject: [PATCH 0/1] async: export current_is_async()

Hi Tejun,

when you introduced current_is_async() with 84b233adcca3, was it a
deliberate decision not to export it? All other non-static functions
in async.c are exported as well.

I'm asking because I would like to use it in i915.ko.

Thanks,

Lukas


Lukas Wunner (1):
async: export current_is_async()

kernel/async.c | 1 +
1 file changed, 1 insertion(+)

--
2.1.0

2015-11-19 15:41:20

by Lukas Wunner

Subject: [PATCH 1/1] async: export current_is_async()

Introduced by 84b233adcca3 ("workqueue: implement current_is_async()").

Cc: Tejun Heo <[email protected]>
Signed-off-by: Lukas Wunner <[email protected]>
---
kernel/async.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/async.c b/kernel/async.c
index 4c3773c..d2edd6e 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -326,3 +326,4 @@ bool current_is_async(void)

return worker && worker->current_func == async_run_entry_fn;
}
+EXPORT_SYMBOL_GPL(current_is_async);
--
2.1.0

2015-11-19 16:10:20

by Tejun Heo

Subject: Re: [PATCH 0/1] async: export current_is_async()

Hello, Lukas.

On Thu, Nov 19, 2015 at 04:31:11PM +0100, Lukas Wunner wrote:
> Hi Tejun,
>
> when you introduced current_is_async() with 84b233adcca3, was it a
> deliberate decision not to export it? All other non-static functions
> in async.c are exported as well.
>
> I'm asking because I would like to use it in i915.ko.

There just was no module user at the time. Please feel free to export
it.

Thanks.

--
tejun

2015-11-19 16:52:26

by Daniel Vetter

Subject: Re: [Intel-gfx] [PATCH 0/1] async: export current_is_async()

On Thu, Nov 19, 2015 at 11:10:16AM -0500, Tejun Heo wrote:
> Hello, Lukas.
>
> On Thu, Nov 19, 2015 at 04:31:11PM +0100, Lukas Wunner wrote:
> > Hi Tejun,
> >
> > when you introduced current_is_async() with 84b233adcca3, was it a
> > deliberate decision not to export it? All other non-static functions
> > in async.c are exported as well.
> >
> > I'm asking because I would like to use it in i915.ko.
>
> There just was no module user at the time. Please feel free to export
> it.

I take that as an ack to pull Lukas' export patch in through drm-intel
trees.

Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch