2015-11-19 07:34:23

by Saurabh Sengar

Subject: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

replacing kmalloc and memset by a single call of kzalloc

Signed-off-by: Saurabh Sengar <[email protected]>
---
v2 : I didn't got any response for my initial patch,
I am sending it again on top of latest kernel(today's)

drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index b6fa257..92dd204 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4956,13 +4956,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
if (RDP_NPORT_ID_SIZE !=
be32_to_cpu(rdp_req->nport_id_desc.length))
goto rjt_logerr;
- rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+ rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
if (!rdp_context) {
rjt_err = LSRJT_UNABLE_TPC;
goto error;
}

- memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
cmd = &cmdiocb->iocb;
rdp_context->ndlp = lpfc_nlp_get(ndlp);
rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
--
1.9.1

2015-11-22 23:14:51

by Sebastian Herbszt

Subject: Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

Saurabh Sengar wrote:
> replacing kmalloc and memset by a single call of kzalloc
>
> Signed-off-by: Saurabh Sengar <[email protected]>
> ---
> v2 : I didn't got any response for my initial patch,
> I am sending it again on top of latest kernel(today's)
>
> drivers/scsi/lpfc/lpfc_els.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index b6fa257..92dd204 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4956,13 +4956,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
> }
>
> - memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
> cmd = &cmdiocb->iocb;
> rdp_context->ndlp = lpfc_nlp_get(ndlp);
> rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;

Same patch was already sent by Punit Vara on 2015-10-24.

Sebastian

2015-12-16 23:21:04

by James Smart

Subject: Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17

Note: Patch 16 contains the exact same patch submitted by Punit Vara. I
posted Punit's change only as it arrived earlier.

-- james s



On 11/18/2015 11:34 PM, Saurabh Sengar wrote:
> replacing kmalloc and memset by a single call of kzalloc
>
> Signed-off-by: Saurabh Sengar <[email protected]>
> ---
> v2 : I didn't got any response for my initial patch,
> I am sending it again on top of latest kernel(today's)
>
> drivers/scsi/lpfc/lpfc_els.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index b6fa257..92dd204 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4956,13 +4956,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
> }
>
> - memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
> cmd = &cmdiocb->iocb;
> rdp_context->ndlp = lpfc_nlp_get(ndlp);
> rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;