2015-11-23 09:57:11

by Saurabh Sengar

Subject: [PATCH] crypto: nx: use of_property_read_u32()

use of_propert_read_u32() for reading int value,
it can help reducing number of variables used

Signed-off-by: Saurabh Sengar <[email protected]>
---
drivers/crypto/nx/nx-842-powernv.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c
index 9ef51fa..87f7a0f 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -525,7 +525,6 @@ static int nx842_powernv_decompress(const unsigned char *in, unsigned int inlen,
static int __init nx842_powernv_probe(struct device_node *dn)
{
struct nx842_coproc *coproc;
- struct property *ct_prop, *ci_prop;
unsigned int ct, ci;
int chip_id;

@@ -534,18 +533,16 @@ static int __init nx842_powernv_probe(struct device_node *dn)
pr_err("ibm,chip-id missing\n");
return -EINVAL;
}
- ct_prop = of_find_property(dn, "ibm,842-coprocessor-type", NULL);
- if (!ct_prop) {
+
+ if (of_property_read_u32(dn, "ibm,842-coprocessor-type", &ct)) {
pr_err("ibm,842-coprocessor-type missing\n");
return -EINVAL;
}
- ct = be32_to_cpu(*(unsigned int *)ct_prop->value);
- ci_prop = of_find_property(dn, "ibm,842-coprocessor-instance", NULL);
- if (!ci_prop) {
+
+ if (of_property_read_u32(dn, "ibm,842-coprocessor-instance", &ci)) {
pr_err("ibm,842-coprocessor-instance missing\n");
return -EINVAL;
}
- ci = be32_to_cpu(*(unsigned int *)ci_prop->value);

coproc = kmalloc(sizeof(*coproc), GFP_KERNEL);
if (!coproc)
--
1.9.1

2015-11-23 14:17:04

by Dan Streetman

Subject: Re: [PATCH] crypto: nx: use of_property_read_u32()

On Mon, Nov 23, 2015 at 4:56 AM, Saurabh Sengar <[email protected]> wrote:
> use of_propert_read_u32() for reading int value,
> it can help reducing number of variables used
>
> Signed-off-by: Saurabh Sengar <[email protected]>

Acked-by: Dan Streetman <[email protected]>

> ---
> drivers/crypto/nx/nx-842-powernv.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c
> index 9ef51fa..87f7a0f 100644
> --- a/drivers/crypto/nx/nx-842-powernv.c
> +++ b/drivers/crypto/nx/nx-842-powernv.c
> @@ -525,7 +525,6 @@ static int nx842_powernv_decompress(const unsigned char *in, unsigned int inlen,
> static int __init nx842_powernv_probe(struct device_node *dn)
> {
> struct nx842_coproc *coproc;
> - struct property *ct_prop, *ci_prop;
> unsigned int ct, ci;
> int chip_id;
>
> @@ -534,18 +533,16 @@ static int __init nx842_powernv_probe(struct device_node *dn)
> pr_err("ibm,chip-id missing\n");
> return -EINVAL;
> }
> - ct_prop = of_find_property(dn, "ibm,842-coprocessor-type", NULL);
> - if (!ct_prop) {
> +
> + if (of_property_read_u32(dn, "ibm,842-coprocessor-type", &ct)) {
> pr_err("ibm,842-coprocessor-type missing\n");
> return -EINVAL;
> }
> - ct = be32_to_cpu(*(unsigned int *)ct_prop->value);
> - ci_prop = of_find_property(dn, "ibm,842-coprocessor-instance", NULL);
> - if (!ci_prop) {
> +
> + if (of_property_read_u32(dn, "ibm,842-coprocessor-instance", &ci)) {
> pr_err("ibm,842-coprocessor-instance missing\n");
> return -EINVAL;
> }
> - ci = be32_to_cpu(*(unsigned int *)ci_prop->value);
>
> coproc = kmalloc(sizeof(*coproc), GFP_KERNEL);
> if (!coproc)
> --
> 1.9.1
>

2015-11-24 10:25:13

by Herbert Xu

Subject: Re: [PATCH] crypto: nx: use of_property_read_u32()

On Mon, Nov 23, 2015 at 03:26:54PM +0530, Saurabh Sengar wrote:
> use of_propert_read_u32() for reading int value,
> it can help reducing number of variables used
>
> Signed-off-by: Saurabh Sengar <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt