Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc.
Caught by coccinelle.
Signed-off-by: Geyslan G. Bem <[email protected]>
---
drivers/usb/host/whci/qset.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c
index dc31c42..3297473 100644
--- a/drivers/usb/host/whci/qset.c
+++ b/drivers/usb/host/whci/qset.c
@@ -30,10 +30,9 @@ struct whc_qset *qset_alloc(struct whc *whc, gfp_t mem_flags)
struct whc_qset *qset;
dma_addr_t dma;
- qset = dma_pool_alloc(whc->qset_pool, mem_flags, &dma);
+ qset = dma_pool_zalloc(whc->qset_pool, mem_flags, &dma);
if (qset == NULL)
return NULL;
- memset(qset, 0, sizeof(struct whc_qset));
qset->qset_dma = dma;
qset->whc = whc;
--
2.6.2
On Wed, Dec 02, 2015 at 05:43:11PM -0300, Geyslan G. Bem wrote:
> Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc.
>
> Caught by coccinelle.
>
> Signed-off-by: Geyslan G. Bem <[email protected]>
> ---
> drivers/usb/host/whci/qset.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
This, and patch 3/3 were also already done by someone else :(
2015-12-04 13:25 GMT-03:00 Greg Kroah-Hartman <[email protected]>:
> On Wed, Dec 02, 2015 at 05:43:11PM -0300, Geyslan G. Bem wrote:
>> Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc.
>>
>> Caught by coccinelle.
>>
>> Signed-off-by: Geyslan G. Bem <[email protected]>
>> ---
>> drivers/usb/host/whci/qset.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> This, and patch 3/3 were also already done by someone else :(
I see. No problem at all.
If you wish, you could list me subsystems in need of maintenance.
Thanks.
--
Regards,
Geyslan G. Bem
hackingbits.com
On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote:
>
> If you wish, you could list me subsystems in need of maintenance.
I don't understand what you mean by this.
2015-12-04 13:44 GMT-03:00 Greg Kroah-Hartman <[email protected]>:
> On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote:
>>
>> If you wish, you could list me subsystems in need of maintenance.
>
> I don't understand what you mean by this.
I meant that would be great to know which usb subsystems you do prefer
that I continue cleaning/refactoring or if any would be ok. :)
--
Regards,
Geyslan G. Bem
hackingbits.com
On Fri, Dec 04, 2015 at 02:13:35PM -0300, Geyslan G. Bem wrote:
> 2015-12-04 13:44 GMT-03:00 Greg Kroah-Hartman <[email protected]>:
> > On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote:
> >>
> >> If you wish, you could list me subsystems in need of maintenance.
> >
> > I don't understand what you mean by this.
>
> I meant that would be great to know which usb subsystems you do prefer
> that I continue cleaning/refactoring or if any would be ok. :)
Any part of the drivers/usb/* tree that you find needs cleanups and
fixes like these are great to do, please send patches for this, I'll
gladly take them.
thanks,
gre k-h
2015-12-04 14:18 GMT-03:00 Greg Kroah-Hartman <[email protected]>:
> On Fri, Dec 04, 2015 at 02:13:35PM -0300, Geyslan G. Bem wrote:
>> 2015-12-04 13:44 GMT-03:00 Greg Kroah-Hartman <[email protected]>:
>> > On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote:
>> >>
>> >> If you wish, you could list me subsystems in need of maintenance.
>> >
>> > I don't understand what you mean by this.
>>
>> I meant that would be great to know which usb subsystems you do prefer
>> that I continue cleaning/refactoring or if any would be ok. :)
>
> Any part of the drivers/usb/* tree that you find needs cleanups and
> fixes like these are great to do, please send patches for this, I'll
> gladly take them.
Nice, I'll indeed.
Thanks.
>
> thanks,
>
> gre k-h
--
Regards,
Geyslan G. Bem
hackingbits.com