2015-12-11 07:46:42

by Valentin Rothberg

[permalink] [raw]
Subject: [PATCH] arch/powerpc/Kconfig: fix typo in select statement

The 'I' in sanitize was missing:
s/ARCH_HAS_UBSAN_SANTIZE_ALL/ARCH_HAS_UBSAN_SANITIZE_ALL/

Fixes: 257e4ee82dbd ("powerpc: enable UBSAN support")
Signed-off-by: Valentin Rothberg <[email protected]>
---
Detected with ./scripts/checkkconfigsymbols.py

arch/powerpc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index b0420a8c458e..4de86d145f17 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -157,7 +157,7 @@ config PPC
select EDAC_ATOMIC_SCRUB
select ARCH_HAS_DMA_SET_COHERENT_MASK
select HAVE_ARCH_SECCOMP_FILTER
- select ARCH_HAS_UBSAN_SANTIZE_ALL
+ select ARCH_HAS_UBSAN_SANITIZE_ALL

config GENERIC_CSUM
def_bool CPU_LITTLE_ENDIAN
--
2.1.4


2015-12-11 08:13:43

by Daniel Axtens

[permalink] [raw]
Subject: Re: [PATCH] arch/powerpc/Kconfig: fix typo in select statement

Thanks Valentin.

Ironically I first noticed the spelling mistake in the original UBSAN
patchset[1], but wanted it to work on powerpc straight away so I went
with the mis-spelled version. It's since been corrected upstream[2]; and
I was going to spin a v2 of my original patch with this fix, especially
since I tagged the original patch as an RFC only. Regardless, thank you:
this should keep -mm and next working in the mean time!

> Fixes: 257e4ee82dbd ("powerpc: enable UBSAN support")
Is this a SHA from linux-next?

Regards,
Daniel

[1]: https://lkml.org/lkml/2015/12/9/1008
[2]: https://lkml.org/lkml/2015/12/10/422


> Signed-off-by: Valentin Rothberg <[email protected]>
> ---
> Detected with ./scripts/checkkconfigsymbols.py
>
> arch/powerpc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index b0420a8c458e..4de86d145f17 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -157,7 +157,7 @@ config PPC
> select EDAC_ATOMIC_SCRUB
> select ARCH_HAS_DMA_SET_COHERENT_MASK
> select HAVE_ARCH_SECCOMP_FILTER
> - select ARCH_HAS_UBSAN_SANTIZE_ALL
> + select ARCH_HAS_UBSAN_SANITIZE_ALL
>
> config GENERIC_CSUM
> def_bool CPU_LITTLE_ENDIAN
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2015-12-11 09:52:01

by Valentin Rothberg

[permalink] [raw]
Subject: Re: [PATCH] arch/powerpc/Kconfig: fix typo in select statement

Hi Daniel,

thank you for the links and the explanation.

On Dec 11 '15 19:13, Daniel Axtens wrote:
> Thanks Valentin.
>
> Ironically I first noticed the spelling mistake in the original UBSAN
> patchset[1], but wanted it to work on powerpc straight away so I went
> with the mis-spelled version. It's since been corrected upstream[2]; and
> I was going to spin a v2 of my original patch with this fix, especially
> since I tagged the original patch as an RFC only. Regardless, thank you:
> this should keep -mm and next working in the mean time!

I haven't seen the fix, sorry for the noise then.

> > Fixes: 257e4ee82dbd ("powerpc: enable UBSAN support")
> Is this a SHA from linux-next?

Yes, it's Linux next. Retrospectively, that was a bad idea :(

Kind regards,
Valentin