2015-12-18 05:49:16

by Wang Nan

Subject: [PATCH] tools build: Add BPF feature check to test-all

Existing test-all.c doesn't check BPF related features. For environment
with all other features enabled, BPF would be considered enabled
without doing real feature check.

This patch adds test-bpf.c into test-all.c.

Signed-off-by: Wang Nan <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Jiri Olsa <[email protected]>
---
tools/build/feature/test-all.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
index 33cf6f2..81025ca 100644
--- a/tools/build/feature/test-all.c
+++ b/tools/build/feature/test-all.c
@@ -125,6 +125,10 @@
# include "test-get_cpuid.c"
#undef main

+#define main main_test_bpf
+# include "test-bpf.c"
+#undef main
+
int main(int argc, char *argv[])
{
main_test_libpython();
@@ -153,6 +157,7 @@ int main(int argc, char *argv[])
main_test_pthread_attr_setaffinity_np();
main_test_lzma();
main_test_get_cpuid();
+ main_test_bpf();

return 0;
}
--
1.8.3.4

2015-12-18 10:15:23

by Jiri Olsa

Subject: Re: [PATCH] tools build: Add BPF feature check to test-all

On Fri, Dec 18, 2015 at 05:48:05AM +0000, Wang Nan wrote:
> Existing test-all.c doesn't check BPF related features. For environment
> with all other features enabled, BPF would be considered enabled
> without doing real feature check.
>
> This patch adds test-bpf.c into test-all.c.
>
> Signed-off-by: Wang Nan <[email protected]>
> Cc: Arnaldo Carvalho de Melo <[email protected]>
> Cc: Namhyung Kim <[email protected]>
> Cc: Jiri Olsa <[email protected]>

nice catch ;-)

Acked-by: Jiri Olsa <[email protected]>

thanks,
jirka