2015-12-18 18:04:40

by Brian Norris

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] mtd: nand: Fix support for NAND DMA prefetch

On Thu, Oct 15, 2015 at 12:37:23PM -0500, Franklin S Cooper Jr wrote:
> NAND DMA prefetch has been broken for awhile and seems to have only
> worked for SDMA based devices
>
> This patchset fixes DMA prefetch to work on both EDMA and SDMA devices
>
> Test on:
> am335x gp evm
> am437x gp evm
> am37x gp evm
>
> This patchset depends on Roger Quadros recent v4 GPMC/NAND patchset
> https://github.com/rogerq/linux.git
> branch: for-v4.4/gpmc-v4

In what way does this depend on the other series? Can any of this be
taken without it? If not, then perhaps it'd be good if Roger can roll
this into his series? Just throwing out ideas. If you want to wait on
Roger's series, that's fine.

FWIW, the MTD stuff all looks OK to me:

Acked-by: Brian Norris <[email protected]>

> Franklin S Cooper Jr (5):
> mtd: nand: omap2: Support parsing dma channel information from DT
> mtd: nand: omap2: Start dma request before enabling prefetch
> mtd: nand: omap2: Fix high memory dma prefetch transfer
> ARM: dts: am437x/am33xx/omap/dm816x: Add gpmc dma channel
> ARM: OMAP2+: Update GPMC and NAND DT binding documentation
>
> .../bindings/memory-controllers/omap-gpmc.txt | 7 +++++-
> .../devicetree/bindings/mtd/gpmc-nand.txt | 2 ++
> arch/arm/boot/dts/am33xx.dtsi | 2 ++
> arch/arm/boot/dts/am4372.dtsi | 2 ++
> arch/arm/boot/dts/dm816x.dtsi | 2 ++
> arch/arm/boot/dts/omap3.dtsi | 2 ++
> arch/arm/boot/dts/omap4.dtsi | 2 ++
> arch/arm/boot/dts/omap5.dtsi | 2 ++
> drivers/mtd/nand/omap2.c | 27 +++++++++-------------
> 9 files changed, 31 insertions(+), 17 deletions(-)
>
> --
> 2.6.1
>


2015-12-30 14:25:59

by Franklin S Cooper Jr

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] mtd: nand: Fix support for NAND DMA prefetch



On 12/18/2015 12:04 PM, Brian Norris wrote:
> On Thu, Oct 15, 2015 at 12:37:23PM -0500, Franklin S Cooper Jr wrote:
>> NAND DMA prefetch has been broken for awhile and seems to have only
>> worked for SDMA based devices
>>
>> This patchset fixes DMA prefetch to work on both EDMA and SDMA devices
>>
>> Test on:
>> am335x gp evm
>> am437x gp evm
>> am37x gp evm
>>
>> This patchset depends on Roger Quadros recent v4 GPMC/NAND patchset
>> https://github.com/rogerq/linux.git
>> branch: for-v4.4/gpmc-v4
> In what way does this depend on the other series? Can any of this be
> taken without it? If not, then perhaps it'd be good if Roger can roll
> this into his series? Just throwing out ideas. If you want to wait on
> Roger's series, that's fine.
>
> FWIW, the MTD stuff all looks OK to me:
>
> Acked-by: Brian Norris <[email protected]>

Patches 2 and 3 doesn't have any dependencies on Roger's
patchset so they should be fine to pull in.

I'll leave it up to Roger if he would like to roll my
patches into his patchset or I can submit the other 3
patches again once he sends out his new patchset.

>> Franklin S Cooper Jr (5):
>> mtd: nand: omap2: Support parsing dma channel information from DT
>> mtd: nand: omap2: Start dma request before enabling prefetch
>> mtd: nand: omap2: Fix high memory dma prefetch transfer
>> ARM: dts: am437x/am33xx/omap/dm816x: Add gpmc dma channel
>> ARM: OMAP2+: Update GPMC and NAND DT binding documentation
>>
>> .../bindings/memory-controllers/omap-gpmc.txt | 7 +++++-
>> .../devicetree/bindings/mtd/gpmc-nand.txt | 2 ++
>> arch/arm/boot/dts/am33xx.dtsi | 2 ++
>> arch/arm/boot/dts/am4372.dtsi | 2 ++
>> arch/arm/boot/dts/dm816x.dtsi | 2 ++
>> arch/arm/boot/dts/omap3.dtsi | 2 ++
>> arch/arm/boot/dts/omap4.dtsi | 2 ++
>> arch/arm/boot/dts/omap5.dtsi | 2 ++
>> drivers/mtd/nand/omap2.c | 27 +++++++++-------------
>> 9 files changed, 31 insertions(+), 17 deletions(-)
>>
>> --
>> 2.6.1
>>