Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this
could make it into 4.4 in order to avoid unpleasent surprises (and
subsequent questions) with builds based on sunxi_defconfig. At the moment,
some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
as a newly added driver is required to power them.
Timo Sigurdsson (1):
ARM: Fix broken USB support in sunxi_defconfig
arch/arm/configs/sunxi_defconfig | 1 +
1 file changed, 1 insertion(+)
--
2.1.4
Commit 69fb4dcada77 ("power: Add an axp20x-usb-power driver") introduced a new
driver for the USB power supply used on various Allwinner based SBCs. However,
the driver was not added to sunxi_defconfig which breaks USB support for some
boards (e.g. LeMaker BananaPi) as the kernel will now turn off the USB power
supply during boot by default if the driver isn't present. (This was not the
case in linux 4.3 or lower where the USB power was always left on.)
Hence, add the driver to sunxi_defconfig in order to keep USB support working
on those boards that require it.
Signed-off-by: Timo Sigurdsson <[email protected]>
Reported-by: David Tulloh <[email protected]>
Tested-by: David Tulloh <[email protected]>
Tested-by: Timo Sigurdsson <[email protected]>
---
arch/arm/configs/sunxi_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
index 3c36e16..b503a89 100644
--- a/arch/arm/configs/sunxi_defconfig
+++ b/arch/arm/configs/sunxi_defconfig
@@ -84,6 +84,7 @@ CONFIG_SPI_SUN4I=y
CONFIG_SPI_SUN6I=y
CONFIG_GPIO_SYSFS=y
CONFIG_POWER_SUPPLY=y
+CONFIG_AXP20X_POWER=y
CONFIG_THERMAL=y
CONFIG_CPU_THERMAL=y
CONFIG_WATCHDOG=y
--
2.1.4
On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
> Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this
> could make it into 4.4 in order to avoid unpleasent surprises (and
> subsequent questions) with builds based on sunxi_defconfig. At the moment,
> some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
> as a newly added driver is required to power them.
It's a bit confusing to send a patch to so many recipients, that usually
leads to nobody applying it. I can put it into the fixes branch in arm-soc
but need an Ack from the sunxi maintainer(s).
Arnd
Hi Arnd,
On Thu, Dec 31, 2015 at 04:46:01PM +0100, Arnd Bergmann wrote:
> On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
> > Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this
> > could make it into 4.4 in order to avoid unpleasent surprises (and
> > subsequent questions) with builds based on sunxi_defconfig. At the moment,
> > some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
> > as a newly added driver is required to power them.
>
> It's a bit confusing to send a patch to so many recipients, that usually
> leads to nobody applying it. I can put it into the fixes branch in arm-soc
> but need an Ack from the sunxi maintainer(s).
You have mine
Acked-by: Maxime Ripard <[email protected]>
Timo, don't we need the same thing for multi_v7?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
On Thursday 31 December 2015 17:00:49 Maxime Ripard wrote:
> Hi Arnd,
>
> On Thu, Dec 31, 2015 at 04:46:01PM +0100, Arnd Bergmann wrote:
> > On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
> > > Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this
> > > could make it into 4.4 in order to avoid unpleasent surprises (and
> > > subsequent questions) with builds based on sunxi_defconfig. At the moment,
> > > some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
> > > as a newly added driver is required to power them.
> >
> > It's a bit confusing to send a patch to so many recipients, that usually
> > leads to nobody applying it. I can put it into the fixes branch in arm-soc
> > but need an Ack from the sunxi maintainer(s).
>
> You have mine
>
> Acked-by: Maxime Ripard <[email protected]>
Thanks!
> Timo, don't we need the same thing for multi_v7?
Good point.
Timo, please create a patch for that one as well and test it, I can
also apply that on the fixes branch.
Arnd
On Thursday 31 December 2015 17:03:25 Arnd Bergmann wrote:
> >
> > You have mine
> >
> > Acked-by: Maxime Ripard <[email protected]>
>
> Thanks!
>
> > Timo, don't we need the same thing for multi_v7?
>
> Good point.
>
> Timo, please create a patch for that one as well and test it, I can
> also apply that on the fixes branch.
>
Forgot to mention, I have applied the original patch it on the fixes branch.
Arnd