On Tue, 2016-09-02 at 03:32:43 UTC, David Gibson wrote:
> htab_get_table_size() either retrieve the size of the hash page table (HPT)
> from the device tree - if the HPT size is determined by firmware - or
> uses a heuristic to determine a good size based on RAM size if the kernel
> is responsible for allocating the HPT.
>
> To support a PAPR extension allowing resizing of the HPT, we're going to
> want the memory size -> HPT size logic elsewhere, so split it out into a
> helper function.
>
> Signed-off-by: David Gibson <[email protected]>
> Reviewed-by: Aneesh Kumar K.V <[email protected]>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5c3c7ede2bdcb85fa2fd51c814
I reworded one comment a little, from:
/* 2^11 PTEGS / 2^18 bytes is the minimum htab size permitted
* by the architecture */
to:
/*
* 2^11 PTEGS of 128 bytes each, ie. 2^18 bytes is the minimum htab
* size permitted by the architecture.
*/
To avoid any confusion about the "/" referring to division.
cheers
On Wed, Mar 02, 2016 at 09:21:19AM +1100, Michael Ellerman wrote:
> On Tue, 2016-09-02 at 03:32:43 UTC, David Gibson wrote:
> > htab_get_table_size() either retrieve the size of the hash page table (HPT)
> > from the device tree - if the HPT size is determined by firmware - or
> > uses a heuristic to determine a good size based on RAM size if the kernel
> > is responsible for allocating the HPT.
> >
> > To support a PAPR extension allowing resizing of the HPT, we're going to
> > want the memory size -> HPT size logic elsewhere, so split it out into a
> > helper function.
> >
> > Signed-off-by: David Gibson <[email protected]>
> > Reviewed-by: Aneesh Kumar K.V <[email protected]>
>
> Applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/5c3c7ede2bdcb85fa2fd51c814
>
> I reworded one comment a little, from:
>
> /* 2^11 PTEGS / 2^18 bytes is the minimum htab size permitted
> * by the architecture */
>
> to:
> /*
> * 2^11 PTEGS of 128 bytes each, ie. 2^18 bytes is the minimum htab
> * size permitted by the architecture.
> */
>
> To avoid any confusion about the "/" referring to division.
Good call, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson