2016-03-02 13:38:51

by Matt Fleming

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] arm64/efi: query Secure Boot status according to UEFI spec

On Thu, 25 Feb, at 05:18:13PM, Linn Crosetto wrote:
> This series modifies the function that queries the status of UEFI Secure Boot
> in the EFI stub to match the UEFI specification, and allow the caller to
> determine if it is enabled, disabled, or in an unknown state due to an
> unexpected error from GetVariable().
>
> v2:
>
> - Add return values for unexpected errors
> - Split changes into two patches
>
> Linn Crosetto (2):
> arm64/efi: report unexpected errors when determining Secure Boot status
> arm64/efi: check SetupMode when determining Secure Boot status
>
> drivers/firmware/efi/libstub/arm-stub.c | 49 +++++++++++++++++++++++++--------
> 1 file changed, 37 insertions(+), 12 deletions(-)

Both of these look fine to me.

Mark, since you gave feedback on the first version, are you happy with
v2?