On Thu, 25 Feb 2016 09:46:55 +0000
Juri Lelli <[email protected]> wrote:
> Hi,
>
> On 24/02/16 14:53, luca abeni wrote:
> > On Tue, 23 Feb 2016 16:42:49 +0100
> > Peter Zijlstra <[email protected]> wrote:
> >
> > > On Mon, Feb 22, 2016 at 11:57:04AM +0100, Luca Abeni wrote:
> > > > switched_to_dl() can be used instead
> > >
> > > This seems unrelated to the other patches, and looks like a nice
> > > cleanup.
> >
> > Ok; I'll rebase the patch on master and I'll run some more serious
> > tests (Juri, your tests repository is available on github, right?
> > Can I assume that if the patch passes your tests then it is ok?).
> > If everything goes well, I'll submit the patch.
> >
>
> Yes, tests reside here https://github.com/jlelli/tests. They should
> give you some confidence that things are not completely broken, but
> of course they might be still broken and you do not notice by running
> such tests. :-)
I am trying these tests, but... Some scripts use "schedtool"; where can
I find a proper version of it (supporting SCHED_DEADLINE)?
I tried https://github.com/scheduler-tools/schedtool-dl but it does not
seem to work correctly...
Thanks,
Luca
Hi Luca,
On 03/03/16 10:03, Luca Abeni wrote:
> On Thu, 25 Feb 2016 09:46:55 +0000
> Juri Lelli <[email protected]> wrote:
>
> > Hi,
> >
> > On 24/02/16 14:53, luca abeni wrote:
> > > On Tue, 23 Feb 2016 16:42:49 +0100
> > > Peter Zijlstra <[email protected]> wrote:
> > >
> > > > On Mon, Feb 22, 2016 at 11:57:04AM +0100, Luca Abeni wrote:
> > > > > switched_to_dl() can be used instead
> > > >
> > > > This seems unrelated to the other patches, and looks like a nice
> > > > cleanup.
> > >
> > > Ok; I'll rebase the patch on master and I'll run some more serious
> > > tests (Juri, your tests repository is available on github, right?
> > > Can I assume that if the patch passes your tests then it is ok?).
> > > If everything goes well, I'll submit the patch.
> > >
> >
> > Yes, tests reside here https://github.com/jlelli/tests. They should
> > give you some confidence that things are not completely broken, but
> > of course they might be still broken and you do not notice by running
> > such tests. :-)
> I am trying these tests, but... Some scripts use "schedtool"; where can
> I find a proper version of it (supporting SCHED_DEADLINE)?
> I tried https://github.com/scheduler-tools/schedtool-dl but it does not
> seem to work correctly...
>
That's the one that I use, and I'm not seeing any problems with it. I'll
send you the binary in private.
Best,
- Juri
On Thu, 3 Mar 2016 09:28:01 +0000
Juri Lelli <[email protected]> wrote:
> That's the one that I use, and I'm not seeing any problems with it. I'll
> send you the binary in private.
That's the one I use too. BTW, Juri, do you plan on submitting patches
to schedtool upstream?
-- Steve
Hi Steven,
On Thu, 3 Mar 2016 09:23:44 -0500
Steven Rostedt <[email protected]> wrote:
> On Thu, 3 Mar 2016 09:28:01 +0000
> Juri Lelli <[email protected]> wrote:
>
> > That's the one that I use, and I'm not seeing any problems with it.
> > I'll send you the binary in private.
>
> That's the one I use too.
Juri provided me with a working binary, and I think I found the cause of
the issue: it works fine on 64bit systems, but fails on 32bit systems.
I think the issue is in the sched_setattr() definition present in
syscall_magic.h (which ignores the "flags" parameter).
Luca
> BTW, Juri, do you plan on submitting patches
> to schedtool upstream?
Hi Steve,
On 03/03/16 09:23, Steven Rostedt wrote:
> On Thu, 3 Mar 2016 09:28:01 +0000
> Juri Lelli <[email protected]> wrote:
>
> > That's the one that I use, and I'm not seeing any problems with it. I'll
> > send you the binary in private.
>
> That's the one I use too. BTW, Juri, do you plan on submitting patches
> to schedtool upstream?
>
Good point, I should. But I don't have any plans ATM :-/. OTOH, if
anyone else wants to do that I'll be more than happy. :-)
Best,
- Juri