If the 'old' operand to cmpxchg() is a constant wider than 21 bits,
linking fails with a "relocation truncated to fit: R_AVR32_21S" error.
Fix this by replacing the "i" constraint with "Ks21" which makes the
compiler use a temporary register for out of range constants.
Signed-off-by: Mans Rullgard <[email protected]>
---
This fixes link errors in linux-next with CONFIG_AIO_THREAD enabled.
---
arch/avr32/include/asm/cmpxchg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/include/asm/cmpxchg.h b/arch/avr32/include/asm/cmpxchg.h
index 366bbeaeb405..572739b4c4b4 100644
--- a/arch/avr32/include/asm/cmpxchg.h
+++ b/arch/avr32/include/asm/cmpxchg.h
@@ -57,7 +57,7 @@ static inline unsigned long __cmpxchg_u32(volatile int *m, unsigned long old,
" brne 1b\n"
"2:\n"
: [ret] "=&r"(ret), [m] "=m"(*m)
- : "m"(m), [old] "ir"(old), [new] "r"(new)
+ : "m"(m), [old] "Ks21r"(old), [new] "r"(new)
: "memory", "cc");
return ret;
}
--
2.7.2
Around Thu 10 Mar 2016 14:23:49 +0000 or thereabout, Mans Rullgard wrote:
> If the 'old' operand to cmpxchg() is a constant wider than 21 bits,
> linking fails with a "relocation truncated to fit: R_AVR32_21S" error.
>
> Fix this by replacing the "i" constraint with "Ks21" which makes the
> compiler use a temporary register for out of range constants.
>
> Signed-off-by: Mans Rullgard <[email protected]>
> ---
> This fixes link errors in linux-next with CONFIG_AIO_THREAD enabled.
Good find, thank you for fixing.
Acked-by: Hans-Christian Noren Egtvedt <[email protected]>
I'll push this for next merge window.
> ---
> arch/avr32/include/asm/cmpxchg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/include/asm/cmpxchg.h b/arch/avr32/include/asm/cmpxchg.h
> index 366bbeaeb405..572739b4c4b4 100644
> --- a/arch/avr32/include/asm/cmpxchg.h
> +++ b/arch/avr32/include/asm/cmpxchg.h
> @@ -57,7 +57,7 @@ static inline unsigned long __cmpxchg_u32(volatile int *m, unsigned long old,
> " brne 1b\n"
> "2:\n"
> : [ret] "=&r"(ret), [m] "=m"(*m)
> - : "m"(m), [old] "ir"(old), [new] "r"(new)
> + : "m"(m), [old] "Ks21r"(old), [new] "r"(new)
> : "memory", "cc");
> return ret;
> }
--
mvh
Hans-Christian Egtvedt
On Thu, Mar 10, 2016 at 4:23 PM, Mans Rullgard <[email protected]> wrote:
> If the 'old' operand to cmpxchg() is a constant wider than 21 bits,
> linking fails with a "relocation truncated to fit: R_AVR32_21S" error.
>
> Fix this by replacing the "i" constraint with "Ks21" which makes the
> compiler use a temporary register for out of range constants.
>
> Signed-off-by: Mans Rullgard <[email protected]>
Tested-by: Andy Shevchenko <[email protected]>
> ---
> This fixes link errors in linux-next with CONFIG_AIO_THREAD enabled.
> ---
> arch/avr32/include/asm/cmpxchg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/include/asm/cmpxchg.h b/arch/avr32/include/asm/cmpxchg.h
> index 366bbeaeb405..572739b4c4b4 100644
> --- a/arch/avr32/include/asm/cmpxchg.h
> +++ b/arch/avr32/include/asm/cmpxchg.h
> @@ -57,7 +57,7 @@ static inline unsigned long __cmpxchg_u32(volatile int *m, unsigned long old,
> " brne 1b\n"
> "2:\n"
> : [ret] "=&r"(ret), [m] "=m"(*m)
> - : "m"(m), [old] "ir"(old), [new] "r"(new)
> + : "m"(m), [old] "Ks21r"(old), [new] "r"(new)
> : "memory", "cc");
> return ret;
> }
> --
> 2.7.2
>
--
With Best Regards,
Andy Shevchenko
On Thursday 10 March 2016 07:53 PM, Mans Rullgard wrote:
> If the 'old' operand to cmpxchg() is a constant wider than 21 bits,
> linking fails with a "relocation truncated to fit: R_AVR32_21S" error.
>
> Fix this by replacing the "i" constraint with "Ks21" which makes the
> compiler use a temporary register for out of range constants.
>
> Signed-off-by: Mans Rullgard <[email protected]>
build log at: https://gitlab.com/sudipm/linux-next/builds/839572
Tested-by: Sudip Mukherjee <[email protected]>
regards
sudip