2016-03-17 02:36:33

by Fengguang Wu

[permalink] [raw]

Subject: [PATCH] microblaze/PCI: export isa_io_base to fix link errors

---

ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
...
ERROR: "isa_io_base" [drivers/watchdog/wdt_pci.ko] undefined!
ERROR: "isa_io_base" [drivers/watchdog/pcwd_pci.ko] undefined!
ERROR: "isa_io_base" [drivers/video/vgastate.ko] undefined!
...
ERROR: "isa_io_base" [drivers/video/fbdev/cirrusfb.ko] undefined!
ERROR: "isa_io_base" [drivers/video/fbdev/arkfb.ko] undefined!
ERROR: "isa_io_base" [drivers/usb/host/uhci-hcd.ko] undefined!
ERROR: "isa_io_base" [drivers/usb/host/isp1362-hcd.ko] undefined!
ERROR: "isa_io_base" [drivers/tty/serial/jsm/jsm.ko] undefined!
ERROR: "isa_io_base" [drivers/tty/serial/8250/8250_pci.ko] undefined!
...
ERROR: "isa_io_base" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!
ERROR: "isa_io_base" [drivers/scsi/ppa.ko] undefined!

Signed-off-by: Fengguang Wu <[email protected]>
---
arch/microblaze/pci/pci-common.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
index ae838ed..fba7a46 100644
--- a/arch/microblaze/pci/pci-common.c
+++ b/arch/microblaze/pci/pci-common.c
@@ -48,6 +48,8 @@ static int global_phb_number; /* Global phb counter */
resource_size_t isa_mem_base;

unsigned long isa_io_base;
+EXPORT_SYMBOL(isa_io_base);
+
static int pci_bus_count;

struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
--
2.7.0.rc3

2016-03-22 00:24:59

by Michal Simek

[permalink] [raw]

Subject: Re: [PATCH] microblaze/PCI: export isa_io_base to fix link errors

---

On 17.3.2016 03:36, Fengguang Wu wrote:
> ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
> ...
> ERROR: "isa_io_base" [drivers/watchdog/wdt_pci.ko] undefined!
> ERROR: "isa_io_base" [drivers/watchdog/pcwd_pci.ko] undefined!
> ERROR: "isa_io_base" [drivers/video/vgastate.ko] undefined!
> ...
> ERROR: "isa_io_base" [drivers/video/fbdev/cirrusfb.ko] undefined!
> ERROR: "isa_io_base" [drivers/video/fbdev/arkfb.ko] undefined!
> ERROR: "isa_io_base" [drivers/usb/host/uhci-hcd.ko] undefined!
> ERROR: "isa_io_base" [drivers/usb/host/isp1362-hcd.ko] undefined!
> ERROR: "isa_io_base" [drivers/tty/serial/jsm/jsm.ko] undefined!
> ERROR: "isa_io_base" [drivers/tty/serial/8250/8250_pci.ko] undefined!
> ...
> ERROR: "isa_io_base" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!
> ERROR: "isa_io_base" [drivers/scsi/ppa.ko] undefined!
>
> Signed-off-by: Fengguang Wu <[email protected]>
> ---
> arch/microblaze/pci/pci-common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
> index ae838ed..fba7a46 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -48,6 +48,8 @@ static int global_phb_number; /* Global phb counter */
> resource_size_t isa_mem_base;
>
> unsigned long isa_io_base;
> +EXPORT_SYMBOL(isa_io_base);
> +
> static int pci_bus_count;
>
> struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
>

Applied.

Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

---

Attachments:

signature.asc (198.00 B)
OpenPGP digital signature