2016-03-18 21:26:58

by Richard Cochran

Subject: [PATCH 1/5] mm: memcontrol: Remove redundant hot plug notifier test.

The test for ONLINE is redundant because the following test for !DEAD
already includes the online case. This patch removes the superfluous
code.

Cc: Johannes Weiner <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Vladimir Davydov <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Richard Cochran <[email protected]>
---
mm/memcontrol.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d06cae2..993a261 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1916,9 +1916,6 @@ static int memcg_cpu_hotplug_callback(struct notifier_block *nb,
int cpu = (unsigned long)hcpu;
struct memcg_stock_pcp *stock;

- if (action == CPU_ONLINE)
- return NOTIFY_OK;
-
if (action != CPU_DEAD && action != CPU_DEAD_FROZEN)
return NOTIFY_OK;

--
2.1.4

2016-03-21 08:17:26

by Michal Hocko

Subject: Re: [PATCH 1/5] mm: memcontrol: Remove redundant hot plug notifier test.

On Fri 18-03-16 22:26:07, Richard Cochran wrote:
> The test for ONLINE is redundant because the following test for !DEAD
> already includes the online case. This patch removes the superfluous
> code.

The code used to do something specific to CPU_ONLINE in the past but now
it really seems to be pointless and maybe even confusing. All we really
care here is when the cpu goes down and we need to drain per-cpu cached
charges.

> Cc: Johannes Weiner <[email protected]>
> Cc: Michal Hocko <[email protected]>
> Cc: Vladimir Davydov <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Richard Cochran <[email protected]>

Acked-by: Michal Hocko <[email protected]>

Thanks

> ---
> mm/memcontrol.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d06cae2..993a261 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1916,9 +1916,6 @@ static int memcg_cpu_hotplug_callback(struct notifier_block *nb,
> int cpu = (unsigned long)hcpu;
> struct memcg_stock_pcp *stock;
>
> - if (action == CPU_ONLINE)
> - return NOTIFY_OK;
> -
> if (action != CPU_DEAD && action != CPU_DEAD_FROZEN)
> return NOTIFY_OK;
>
> --
> 2.1.4

--
Michal Hocko
SUSE Labs