2016-03-21 22:57:26

by Mark Fasheh

[permalink] [raw]
Subject: Re: [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote:
> Implement online file check sysfile interfaces, e.g.
> how to create the related sysfile according to device name,
> how to display/handle file check request from the sysfile.
>
> Signed-off-by: Gang He <[email protected]>
Reviewed-by: Mark Fasheh <[email protected]>

--
Mark Fasheh


2016-03-21 23:05:49

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

On Mon, 21 Mar 2016 15:57:23 -0700 Mark Fasheh <[email protected]> wrote:

> On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote:
> > Implement online file check sysfile interfaces, e.g.
> > how to create the related sysfile according to device name,
> > how to display/handle file check request from the sysfile.
> >
> > Signed-off-by: Gang He <[email protected]>
> Reviewed-by: Mark Fasheh <[email protected]>

Thanks. So all of

ocfs2-export-ocfs2_kset-for-online-file-check.patch
ocfs2-sysfile-interfaces-for-online-file-check.patch
ocfs2-sysfile-interfaces-for-online-file-check-v4.patch
ocfs2-create-remove-sysfile-for-online-file-check.patch
ocfs2-check-fix-inode-block-for-online-file-check.patch
ocfs2-check-fix-inode-block-for-online-file-check-v4.patch
ocfs2-add-feature-document-for-online-file-check.patch

have your reviewed-by. I'll send them on to Linus.

2016-03-21 23:38:07

by Mark Fasheh

[permalink] [raw]
Subject: Re: [Ocfs2-devel] [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

On Mon, Mar 21, 2016 at 04:05:47PM -0700, Andrew Morton wrote:
> On Mon, 21 Mar 2016 15:57:23 -0700 Mark Fasheh <[email protected]> wrote:
>
> > On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote:
> > > Implement online file check sysfile interfaces, e.g.
> > > how to create the related sysfile according to device name,
> > > how to display/handle file check request from the sysfile.
> > >
> > > Signed-off-by: Gang He <[email protected]>
> > Reviewed-by: Mark Fasheh <[email protected]>
>
> Thanks. So all of
>
> ocfs2-export-ocfs2_kset-for-online-file-check.patch
> ocfs2-sysfile-interfaces-for-online-file-check.patch
> ocfs2-sysfile-interfaces-for-online-file-check-v4.patch
> ocfs2-create-remove-sysfile-for-online-file-check.patch
> ocfs2-check-fix-inode-block-for-online-file-check.patch
> ocfs2-check-fix-inode-block-for-online-file-check-v4.patch
> ocfs2-add-feature-document-for-online-file-check.patch
>
> have your reviewed-by. I'll send them on to Linus.

I'm curious, are the '-V4' patches built on top of the non '-V4' versions?

Otherwise though this generally sounds good to me - I have reviewed the
entire online fsck patch series.
--Mark

--
Mark Fasheh

2016-03-22 01:00:40

by Andrew Morton

[permalink] [raw]
Subject: Re: [Ocfs2-devel] [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

On Mon, 21 Mar 2016 16:38:02 -0700 Mark Fasheh <[email protected]> wrote:

> On Mon, Mar 21, 2016 at 04:05:47PM -0700, Andrew Morton wrote:
> > On Mon, 21 Mar 2016 15:57:23 -0700 Mark Fasheh <[email protected]> wrote:
> >
> > > On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote:
> > > > Implement online file check sysfile interfaces, e.g.
> > > > how to create the related sysfile according to device name,
> > > > how to display/handle file check request from the sysfile.
> > > >
> > > > Signed-off-by: Gang He <[email protected]>
> > > Reviewed-by: Mark Fasheh <[email protected]>
> >
> > Thanks. So all of
> >
> > ocfs2-export-ocfs2_kset-for-online-file-check.patch
> > ocfs2-sysfile-interfaces-for-online-file-check.patch
> > ocfs2-sysfile-interfaces-for-online-file-check-v4.patch
> > ocfs2-create-remove-sysfile-for-online-file-check.patch
> > ocfs2-check-fix-inode-block-for-online-file-check.patch
> > ocfs2-check-fix-inode-block-for-online-file-check-v4.patch
> > ocfs2-add-feature-document-for-online-file-check.patch
> >
> > have your reviewed-by. I'll send them on to Linus.
>
> I'm curious, are the '-V4' patches built on top of the non '-V4' versions?

yes, the -v4 patches bring the base patch from
whatever-version-i-originally-merged up to v4.

> Otherwise though this generally sounds good to me - I have reviewed the
> entire online fsck patch series.

Cool.

2016-03-22 02:15:53

by Gang He

[permalink] [raw]
Subject: Re: [Ocfs2-devel] [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

Hello Mark and Andrew,

Thank for taking the time in reviewing the patches, move the thing forward.


Thanks
Gang




>>>
> On Mon, 21 Mar 2016 16:38:02 -0700 Mark Fasheh <[email protected]> wrote:
>
>> On Mon, Mar 21, 2016 at 04:05:47PM -0700, Andrew Morton wrote:
>> > On Mon, 21 Mar 2016 15:57:23 -0700 Mark Fasheh <[email protected]> wrote:
>> >
>> > > On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote:
>> > > > Implement online file check sysfile interfaces, e.g.
>> > > > how to create the related sysfile according to device name,
>> > > > how to display/handle file check request from the sysfile.
>> > > >
>> > > > Signed-off-by: Gang He <[email protected]>
>> > > Reviewed-by: Mark Fasheh <[email protected]>
>> >
>> > Thanks. So all of
>> >
>> > ocfs2-export-ocfs2_kset-for-online-file-check.patch
>> > ocfs2-sysfile-interfaces-for-online-file-check.patch
>> > ocfs2-sysfile-interfaces-for-online-file-check-v4.patch
>> > ocfs2-create-remove-sysfile-for-online-file-check.patch
>> > ocfs2-check-fix-inode-block-for-online-file-check.patch
>> > ocfs2-check-fix-inode-block-for-online-file-check-v4.patch
>> > ocfs2-add-feature-document-for-online-file-check.patch
>> >
>> > have your reviewed-by. I'll send them on to Linus.
>>
>> I'm curious, are the '-V4' patches built on top of the non '-V4' versions?
>
> yes, the -v4 patches bring the base patch from
> whatever-version-i-originally-merged up to v4.
>
>> Otherwise though this generally sounds good to me - I have reviewed the
>> entire online fsck patch series.
>
> Cool.
>
> _______________________________________________
> Ocfs2-devel mailing list
> [email protected]
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel