2016-03-12 08:40:46

by Bo YU

Subject: [PATCH] staging: xgifb: Fix comment style

Fix comments to use trailing */ on separste lines.

Signed-off-by: YU BO <[email protected]>
---
drivers/staging/xgifb/vb_init.c | 3 ++-
drivers/staging/xgifb/vb_setmode.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 26b539bc6faf..572487388e81 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -355,7 +355,8 @@ static void XGINew_DDR2_DefaultRegister(
unsigned long P3d4 = Port, P3c4 = Port - 0x10;

/* keep following setting sequence, each setting in
- * the same reg insert idle */
+ * the same reg insert idle
+ */
xgifb_reg_set(P3d4, 0x82, 0x77);
xgifb_reg_set(P3d4, 0x86, 0x00);
xgifb_reg_get(P3d4, 0x86); /* Insert read command for delay */
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index f97c77d88173..240d4257bc2f 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1992,7 +1992,8 @@ static void XGI_GetVBInfo(unsigned short ModeIdIndex,
}

/* LCD+TV can't support in slave mode
- * (Force LCDA+TV->LCDB) */
+ * (Force LCDA+TV->LCDB)
+ */
if ((tempbx & SetInSlaveMode) && (tempbx & XGI_SetCRT2ToLCDA)) {
tempbx ^= (SetCRT2ToLCD | XGI_SetCRT2ToLCDA |
SetCRT2ToDualEdge);
--
1.7.10.4

2016-03-21 19:38:25

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: xgifb: Fix comment style

On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote:
> Fix comments to use trailing */ on separste lines.
>
> Signed-off-by: YU BO <[email protected]>
> ---
> drivers/staging/xgifb/vb_init.c | 3 ++-
> drivers/staging/xgifb/vb_setmode.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)

You sent me 2 different patches with the identical subject: line, which
I can't accept. Please fix them up and send a patch series, with unique
subjects.

thanks,

greg k-h

2016-03-22 08:56:46

by Bo YU

Subject: Re: [PATCH] staging: xgifb: Fix comment style

On Mon, Mar 21, 2016 at 03:38:21PM -0400, Kroah-Hartman wrote:
hi,
>On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote:
>> Fix comments to use trailing */ on separste lines.
>>
>> Signed-off-by: YU BO <[email protected]>
>> ---
>> drivers/staging/xgifb/vb_init.c | 3 ++-
>> drivers/staging/xgifb/vb_setmode.c | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>You sent me 2 different patches with the identical subject: line, which
>I can't accept. Please fix them up and send a patch series, with unique
>subjects.
yes, you are right:) I will fix them up and resend a patch series.
Sorry for the noise.
Thanks.
>
>thanks,
>
>greg k-h