2016-03-22 11:40:25

by Dan Carpenter

Subject: [patch] ufs: silence uninitialized warnings

Static checkers complain that we can use "tmp" without initializing it.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/fs/ufs/util.h b/fs/ufs/util.h
index 9541759..8aa8812 100644
--- a/fs/ufs/util.h
+++ b/fs/ufs/util.h
@@ -88,7 +88,7 @@ ufs_get_fs_npsect(struct super_block *sb, struct ufs_super_block_first *usb1,
static inline u64
ufs_get_fs_qbmask(struct super_block *sb, struct ufs_super_block_third *usb3)
{
- __fs64 tmp;
+ __fs64 tmp = 0;

switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
case UFS_ST_SUNOS:
@@ -112,7 +112,7 @@ ufs_get_fs_qbmask(struct super_block *sb, struct ufs_super_block_third *usb3)
static inline u64
ufs_get_fs_qfmask(struct super_block *sb, struct ufs_super_block_third *usb3)
{
- __fs64 tmp;
+ __fs64 tmp = 0;

switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
case UFS_ST_SUNOS:

2016-03-22 14:03:54

by Evgeniy Dushistov

Subject: Re: [patch] ufs: silence uninitialized warnings

On Tue, Mar 22, 2016 at 02:40:02PM +0300, Dan Carpenter wrote:
> Static checkers complain that we can use "tmp" without initializing it.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/fs/ufs/util.h b/fs/ufs/util.h
> index 9541759..8aa8812 100644
> --- a/fs/ufs/util.h
> +++ b/fs/ufs/util.h
> @@ -88,7 +88,7 @@ ufs_get_fs_npsect(struct super_block *sb, struct ufs_super_block_first *usb1,
> static inline u64
> ufs_get_fs_qbmask(struct super_block *sb, struct ufs_super_block_third *usb3)
> {
> - __fs64 tmp;
> + __fs64 tmp = 0;
>
> switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
> case UFS_ST_SUNOS:
> @@ -112,7 +112,7 @@ ufs_get_fs_qbmask(struct super_block *sb, struct ufs_super_block_third *usb3)
> static inline u64
> ufs_get_fs_qfmask(struct super_block *sb, struct ufs_super_block_third *usb3)
> {
> - __fs64 tmp;
> + __fs64 tmp = 0;
>
> switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
> case UFS_ST_SUNOS:

In fact result of this function is saved, but not used.
May be better from cleanup point of view will be remove these two
functions and structure fields where their result was saved.

--
/Evgeniy