2016-03-28 21:56:53

by Kees Cook

[permalink] [raw]
Subject: [PATCH] bpf: doc: "neg" opcode has no operands

From: Dave Anderson <[email protected]>

Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
and thus has no addressing modes.

Signed-off-by: Dave Anderson <[email protected]>
Signed-off-by: Kees Cook <[email protected]>
---
Documentation/networking/filter.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/filter.txt b/Documentation/networking/filter.txt
index 96da119a47e7..11f67f181d39 100644
--- a/Documentation/networking/filter.txt
+++ b/Documentation/networking/filter.txt
@@ -230,7 +230,7 @@ opcodes as defined in linux/filter.h stand for:
mul 0, 4 A * <x>
div 0, 4 A / <x>
mod 0, 4 A % <x>
- neg 0, 4 !A
+ neg !A
and 0, 4 A & <x>
or 0, 4 A | <x>
xor 0, 4 A ^ <x>
--
2.6.3


--
Kees Cook
Chrome OS & Brillo Security


2016-03-29 00:32:24

by Alexei Starovoitov

[permalink] [raw]
Subject: Re: [PATCH] bpf: doc: "neg" opcode has no operands

On Mon, Mar 28, 2016 at 02:56:47PM -0700, Kees Cook wrote:
> From: Dave Anderson <[email protected]>
>
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.
>
> Signed-off-by: Dave Anderson <[email protected]>
> Signed-off-by: Kees Cook <[email protected]>

Acked-by: Alexei Starovoitov <[email protected]>

2016-03-29 07:58:06

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH] bpf: doc: "neg" opcode has no operands

On 03/28/2016 11:56 PM, Kees Cook wrote:
> From: Dave Anderson <[email protected]>
>
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.
>
> Signed-off-by: Dave Anderson <[email protected]>
> Signed-off-by: Kees Cook <[email protected]>

Acked-by: Daniel Borkmann <[email protected]>

2016-03-31 06:32:12

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] bpf: doc: "neg" opcode has no operands

On Mon, 28 Mar 2016 14:56:47 -0700
Kees Cook <[email protected]> wrote:

> From: Dave Anderson <[email protected]>
>
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.

I've applied this to the docs tree, thanks.

jon