Correct a typo in the chunk_mutex name to make it grepable.
Since it is better to fix several typos at once, fixing the 2 more in the
same file.
Signed-off-by: Luis de Bethencourt <[email protected]>
---
Hi,
Sorry for sending again. Previous version had a line over 80 characters.
Explanation from previous patch:
David recommended I look around the rest of the file for other typos to fix.
These two more are all I see in the rest of the file without nitpicking.
Thanks and apologies for sending v3 without thoroughly checking,
Luis
fs/btrfs/super.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 7e766ffc..bc060cf 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1484,10 +1484,10 @@ static int setup_security_options(struct btrfs_fs_info *fs_info,
memcpy(&fs_info->security_opts, sec_opts, sizeof(*sec_opts));
} else {
/*
- * Since SELinux(the only one supports security_mnt_opts) does
- * NOT support changing context during remount/mount same sb,
- * This must be the same or part of the same security options,
- * just free it.
+ * Since SELinux (the only one supporting security_mnt_opts)
+ * does NOT support changing context during remount/mount of
+ * the same sb, this must be the same or part of the same
+ * security options, just free it.
*/
security_free_mnt_opts(sec_opts);
}
@@ -1665,8 +1665,8 @@ static inline void btrfs_remount_cleanup(struct btrfs_fs_info *fs_info,
unsigned long old_opts)
{
/*
- * We need cleanup all defragable inodes if the autodefragment is
- * close or the fs is R/O.
+ * We need to cleanup all defragable inodes if the autodefragment is
+ * close or the filesystem is read only.
*/
if (btrfs_raw_test_opt(old_opts, AUTO_DEFRAG) &&
(!btrfs_raw_test_opt(fs_info->mount_opt, AUTO_DEFRAG) ||
@@ -2050,7 +2050,7 @@ static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf)
int mixed = 0;
/*
- * holding chunk_muext to avoid allocating new chunks, holding
+ * holding chunk_mutex to avoid allocating new chunks, holding
* device_list_mutex to avoid the device being removed
*/
rcu_read_lock();
--
2.6.4
On Mon, Apr 04, 2016 at 03:31:22PM +0100, Luis de Bethencourt wrote:
> Correct a typo in the chunk_mutex name to make it grepable.
>
> Since it is better to fix several typos at once, fixing the 2 more in the
> same file.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
Now the subject does not match the patch contents, but I can fix that so
you don't have to resend it again.
On 04/04/16 15:45, David Sterba wrote:
> On Mon, Apr 04, 2016 at 03:31:22PM +0100, Luis de Bethencourt wrote:
>> Correct a typo in the chunk_mutex name to make it grepable.
>>
>> Since it is better to fix several typos at once, fixing the 2 more in the
>> same file.
>>
>> Signed-off-by: Luis de Bethencourt <[email protected]>
>
> Now the subject does not match the patch contents, but I can fix that so
> you don't have to resend it again.
>
Sorry David. That was a poor decision by me of keeping the subject by
considering the typo in btrfs_statfs() as the core and the other two as
appended corrections.
Thank you for fixing it. I understand what you mean.
In an unrelated note, do you think this bug would be a good one for me
to tackle?
https://bugzilla.kernel.org/show_bug.cgi?id=115851
Thanks,
Luis