2016-04-01 10:42:29

by Kunihiko Hayashi

[permalink] [raw]
Subject: [PATCH] bus: uniphier-system-bus: fix condition of overlap check

This patch fixes condition whether the specified address ranges
overlap each other.

Fixes: 4b7f48d395a7 ("bus: uniphier-system-bus: add UniPhier System Bus driver")
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
drivers/bus/uniphier-system-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/uniphier-system-bus.c b/drivers/bus/uniphier-system-bus.c
index 834a2ae..350b730 100644
--- a/drivers/bus/uniphier-system-bus.c
+++ b/drivers/bus/uniphier-system-bus.c
@@ -108,7 +108,7 @@ static int uniphier_system_bus_check_overlap(

for (i = 0; i < ARRAY_SIZE(priv->bank); i++) {
for (j = i + 1; j < ARRAY_SIZE(priv->bank); j++) {
- if (priv->bank[i].end > priv->bank[j].base ||
+ if (priv->bank[i].end > priv->bank[j].base &&
priv->bank[i].base < priv->bank[j].end) {
dev_err(priv->dev,
"region overlap between bank%d and bank%d\n",
--
2.1.4



2016-04-07 14:00:16

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] bus: uniphier-system-bus: fix condition of overlap check

2016-04-01 19:32 GMT+09:00 Kunihiko Hayashi <[email protected]>:
> This patch fixes condition whether the specified address ranges
> overlap each other.
>
> Fixes: 4b7f48d395a7 ("bus: uniphier-system-bus: add UniPhier System Bus driver")
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---

Acked-by: Masahiro Yamada <[email protected]>


Arnd, Olof,

Could you pick up this bug-fix for v4.6, please?


--
Best Regards
Masahiro Yamada

2016-04-12 19:37:55

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH] bus: uniphier-system-bus: fix condition of overlap check

On Thu, Apr 07, 2016 at 10:59:48PM +0900, Masahiro Yamada wrote:
> 2016-04-01 19:32 GMT+09:00 Kunihiko Hayashi <[email protected]>:
> > This patch fixes condition whether the specified address ranges
> > overlap each other.
> >
> > Fixes: 4b7f48d395a7 ("bus: uniphier-system-bus: add UniPhier System Bus driver")
> > Signed-off-by: Kunihiko Hayashi <[email protected]>
> > ---
>
> Acked-by: Masahiro Yamada <[email protected]>
>
>
> Arnd, Olof,
>
> Could you pick up this bug-fix for v4.6, please?

Applied to fixes.


-Olof