2016-03-13 00:39:45

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] kbuild: specify modules(_install) as PHONY rather than FORCE

As in other places, PHONY is a better fit for "modules" and
"modules_install".

Signed-off-by: Masahiro Yamada <[email protected]>
---

Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index e3ef6b6..64cf099 100644
--- a/Makefile
+++ b/Makefile
@@ -1157,7 +1157,8 @@ else # CONFIG_MODULES
# Modules not configured
# ---------------------------------------------------------------------------

-modules modules_install: FORCE
+PHONY += modules modules_install
+modules modules_install:
@echo >&2
@echo >&2 "The present kernel configuration has modules disabled."
@echo >&2 "Type 'make config' and enable loadable module support."
--
1.9.1


2016-04-20 08:30:15

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH] kbuild: specify modules(_install) as PHONY rather than FORCE

On Sun, Mar 13, 2016 at 09:39:22AM +0900, Masahiro Yamada wrote:
> As in other places, PHONY is a better fit for "modules" and
> "modules_install".
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Applied to kbuild.git#kbuild.

Michal