2016-04-21 08:44:08

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 1/8] cpufreq: berlin: Use generic platdev driver

The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform
device now, reuse that and remove similar code from platform code.

Cc: Antoine Tenart <[email protected]>
Cc: Sebastian Hesselbarth <[email protected]>
Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm/mach-berlin/berlin.c | 6 ------
drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++
2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-berlin/berlin.c b/arch/arm/mach-berlin/berlin.c
index 25d73870ccca..ac181c6797ee 100644
--- a/arch/arm/mach-berlin/berlin.c
+++ b/arch/arm/mach-berlin/berlin.c
@@ -18,11 +18,6 @@
#include <asm/hardware/cache-l2x0.h>
#include <asm/mach/arch.h>

-static void __init berlin_init_late(void)
-{
- platform_device_register_simple("cpufreq-dt", -1, NULL, 0);
-}
-
static const char * const berlin_dt_compat[] = {
"marvell,berlin",
NULL,
@@ -30,7 +25,6 @@ static const char * const berlin_dt_compat[] = {

DT_MACHINE_START(BERLIN_DT, "Marvell Berlin")
.dt_compat = berlin_dt_compat,
- .init_late = berlin_init_late,
/*
* with DT probing for L2CCs, berlin_init_machine can be removed.
* Note: 88DE3005 (Armada 1500-mini) uses pl310 l2cc
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index f2ae7ad99a3c..3b3e6804cf14 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -12,6 +12,8 @@
#include <linux/platform_device.h>

static const struct of_device_id machines[] = {
+ { .compatible = "marvell,berlin", },
+
{ .compatible = "samsung,exynos3250", },
{ .compatible = "samsung,exynos4210", },
{ .compatible = "samsung,exynos4212", },
--
2.7.1.410.g6faf27b


2016-04-21 09:05:45

by Antoine Tenart

[permalink] [raw]
Subject: Re: [PATCH 1/8] cpufreq: berlin: Use generic platdev driver

Hi,

On Thu, Apr 21, 2016 at 02:13:47PM +0530, Viresh Kumar wrote:
> The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform
> device now, reuse that and remove similar code from platform code.
>
> Cc: Antoine Tenart <[email protected]>
> Cc: Sebastian Hesselbarth <[email protected]>
> Signed-off-by: Viresh Kumar <[email protected]>

Acked-by: Antoine Tenart <[email protected]>

Thanks!

Antoine

> ---
> arch/arm/mach-berlin/berlin.c | 6 ------
> drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-berlin/berlin.c b/arch/arm/mach-berlin/berlin.c
> index 25d73870ccca..ac181c6797ee 100644
> --- a/arch/arm/mach-berlin/berlin.c
> +++ b/arch/arm/mach-berlin/berlin.c
> @@ -18,11 +18,6 @@
> #include <asm/hardware/cache-l2x0.h>
> #include <asm/mach/arch.h>
>
> -static void __init berlin_init_late(void)
> -{
> - platform_device_register_simple("cpufreq-dt", -1, NULL, 0);
> -}
> -
> static const char * const berlin_dt_compat[] = {
> "marvell,berlin",
> NULL,
> @@ -30,7 +25,6 @@ static const char * const berlin_dt_compat[] = {
>
> DT_MACHINE_START(BERLIN_DT, "Marvell Berlin")
> .dt_compat = berlin_dt_compat,
> - .init_late = berlin_init_late,
> /*
> * with DT probing for L2CCs, berlin_init_machine can be removed.
> * Note: 88DE3005 (Armada 1500-mini) uses pl310 l2cc
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index f2ae7ad99a3c..3b3e6804cf14 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -12,6 +12,8 @@
> #include <linux/platform_device.h>
>
> static const struct of_device_id machines[] = {
> + { .compatible = "marvell,berlin", },
> +
> { .compatible = "samsung,exynos3250", },
> { .compatible = "samsung,exynos4210", },
> { .compatible = "samsung,exynos4212", },
> --
> 2.7.1.410.g6faf27b
>

--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


Attachments:
(No filename) (2.06 kB)
signature.asc (819.00 B)
Digital signature
Download all attachments