2016-04-16 06:20:59

by Ivaylo Dimitrov

[permalink] [raw]
Subject: [PATCH] ARM: dts: omap3: Fix ISP syscon register offset

According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c

Signed-off-by: Ivaylo Dimitrov <[email protected]>
---
arch/arm/boot/dts/omap34xx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
index 5cdba1f..e446562 100644
--- a/arch/arm/boot/dts/omap34xx.dtsi
+++ b/arch/arm/boot/dts/omap34xx.dtsi
@@ -46,7 +46,7 @@
0x480bd800 0x017c>;
interrupts = <24>;
iommus = <&mmu_isp>;
- syscon = <&scm_conf 0xdc>;
+ syscon = <&scm_conf 0x6c>;
ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
#clock-cells = <1>;
ports {
--
1.9.1


2016-04-22 04:34:51

by Ivaylo Dimitrov

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: omap3: Fix ISP syscon register offset



On 16.04.2016 09:20, Ivaylo Dimitrov wrote:
> According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c
>
> Signed-off-by: Ivaylo Dimitrov <[email protected]>
> ---
> arch/arm/boot/dts/omap34xx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> index 5cdba1f..e446562 100644
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -46,7 +46,7 @@
> 0x480bd800 0x017c>;
> interrupts = <24>;
> iommus = <&mmu_isp>;
> - syscon = <&scm_conf 0xdc>;
> + syscon = <&scm_conf 0x6c>;
> ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
> #clock-cells = <1>;
> ports {
>

Anyone going to review that?

2016-04-22 13:16:34

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: omap3: Fix ISP syscon register offset

Hi,

On Fri, Apr 22, 2016 at 07:34:43AM +0300, Ivaylo Dimitrov wrote:
> On 16.04.2016 09:20, Ivaylo Dimitrov wrote:
> >According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c
> >
> >Signed-off-by: Ivaylo Dimitrov <[email protected]>
> >---
> > arch/arm/boot/dts/omap34xx.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> >index 5cdba1f..e446562 100644
> >--- a/arch/arm/boot/dts/omap34xx.dtsi
> >+++ b/arch/arm/boot/dts/omap34xx.dtsi
> >@@ -46,7 +46,7 @@
> > 0x480bd800 0x017c>;
> > interrupts = <24>;
> > iommus = <&mmu_isp>;
> >- syscon = <&scm_conf 0xdc>;
> >+ syscon = <&scm_conf 0x6c>;
> > ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
> > #clock-cells = <1>;
> > ports {
> >

You may want to add the hint, that 0xdc (the old, wrong "offset")
represents the last few bits of the register address. I guess
somebody didn't notice, that scm_conf does not start at a register
address ending with 00 (like most other modules).

Reviewed-By: Sebastian Reichel <[email protected]>

-- Sebastian

Attachments:
(No filename) (1.12 kB)
 signature.asc (819.00 B)
 Download all attachments

2016-04-26 17:12:53

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: omap3: Fix ISP syscon register offset

* Sebastian Reichel <[email protected]> [160422 06:17]:
> Hi,
>
> On Fri, Apr 22, 2016 at 07:34:43AM +0300, Ivaylo Dimitrov wrote:
> > On 16.04.2016 09:20, Ivaylo Dimitrov wrote:
> > >According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c
> > >
> > >Signed-off-by: Ivaylo Dimitrov <[email protected]>
> > >---
> > > arch/arm/boot/dts/omap34xx.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> > >index 5cdba1f..e446562 100644
> > >--- a/arch/arm/boot/dts/omap34xx.dtsi
> > >+++ b/arch/arm/boot/dts/omap34xx.dtsi
> > >@@ -46,7 +46,7 @@
> > > 0x480bd800 0x017c>;
> > > interrupts = <24>;
> > > iommus = <&mmu_isp>;
> > >- syscon = <&scm_conf 0xdc>;
> > >+ syscon = <&scm_conf 0x6c>;
> > > ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
> > > #clock-cells = <1>;
> > > ports {
> > >
>
> You may want to add the hint, that 0xdc (the old, wrong "offset")
> represents the last few bits of the register address. I guess
> somebody didn't notice, that scm_conf does not start at a register
> address ending with 00 (like most other modules).
>
> Reviewed-By: Sebastian Reichel <[email protected]>

Applying into omap-for-v4.6/fixes-rc5 thanks.

Tony