2016-04-21 08:59:37

by Viresh Kumar

Subject: [PATCH 05/10] PM / OPP: Mark shared-opp for non-dt case

opp core allows OPPs to be explicitly marked as shared from platform
code, in case of operating-point v1 bindings.

Though we do everything fine in that case, we don't set the flag in the
opp-table to indicate that the OPPs are shared. It works fine today as
the flag isn't used anywhere else in the core, but we should be doing
the right thing by marking it set.

Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/base/power/opp/cpu.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power/opp/cpu.c
index 491e8684bd5f..55cbf9bd8707 100644
--- a/drivers/base/power/opp/cpu.c
+++ b/drivers/base/power/opp/cpu.c
@@ -319,6 +319,9 @@ int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
__func__, cpu);
continue;
}
+
+ /* Mark opp-table as multiple CPUs are sharing it now */
+ opp_table->shared_opp = true;
}
unlock:
mutex_unlock(&opp_table_lock);
--
2.7.1.410.g6faf27b

2016-04-22 22:21:43

by Stephen Boyd

Subject: Re: [PATCH 05/10] PM / OPP: Mark shared-opp for non-dt case

On 04/21, Viresh Kumar wrote:
> opp core allows OPPs to be explicitly marked as shared from platform
> code, in case of operating-point v1 bindings.
>
> Though we do everything fine in that case, we don't set the flag in the
> opp-table to indicate that the OPPs are shared. It works fine today as
> the flag isn't used anywhere else in the core, but we should be doing
> the right thing by marking it set.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project