2016-03-30 06:49:32

by Jisheng Zhang

Subject: [PATCH v2] ARM: reboot: remove duplicated local_irq_disable()

Once entering machine_halt() and machine_restart(), local_irq_disable()
is called, and local irq is kept disabled, so the local_irq_disable()
at the end of these two functions are not necessary, remove it.

Signed-off-by: Jisheng Zhang <[email protected]>
---

Since v1:
- correct typo in commit msg

arch/arm/kernel/reboot.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
index 71a2ff9..3fa867a 100644
--- a/arch/arm/kernel/reboot.c
+++ b/arch/arm/kernel/reboot.c
@@ -104,8 +104,6 @@ void machine_halt(void)
{
local_irq_disable();
smp_send_stop();
-
- local_irq_disable();
while (1);
}

@@ -150,6 +148,5 @@ void machine_restart(char *cmd)

/* Whoops - the platform was unable to reboot. Tell the user! */
printk("Reboot failed -- System halted\n");
- local_irq_disable();
while (1);
}
--
2.8.0.rc3

2016-04-27 09:26:34

by Jisheng Zhang

Subject: Re: [PATCH v2] ARM: reboot: remove duplicated local_irq_disable()

Dear Russell,

On Wed, 30 Mar 2016 14:45:08 +0800 Jisheng Zhang wrote:

> Once entering machine_halt() and machine_restart(), local_irq_disable()
> is called, and local irq is kept disabled, so the local_irq_disable()
> at the end of these two functions are not necessary, remove it.

Could I put the patch in your patch tracking system?

Thanks,
Jisheng

>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
>
> Since v1:
> - correct typo in commit msg
>
> arch/arm/kernel/reboot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
> index 71a2ff9..3fa867a 100644
> --- a/arch/arm/kernel/reboot.c
> +++ b/arch/arm/kernel/reboot.c
> @@ -104,8 +104,6 @@ void machine_halt(void)
> {
> local_irq_disable();
> smp_send_stop();
> -
> - local_irq_disable();
> while (1);
> }
>
> @@ -150,6 +148,5 @@ void machine_restart(char *cmd)
>
> /* Whoops - the platform was unable to reboot. Tell the user! */
> printk("Reboot failed -- System halted\n");
> - local_irq_disable();
> while (1);
> }

2016-04-28 13:45:13

by Russell King - ARM Linux

Subject: Re: [PATCH v2] ARM: reboot: remove duplicated local_irq_disable()

On Wed, Apr 27, 2016 at 05:22:11PM +0800, Jisheng Zhang wrote:
> Dear Russell,
>
> On Wed, 30 Mar 2016 14:45:08 +0800 Jisheng Zhang wrote:
>
> > Once entering machine_halt() and machine_restart(), local_irq_disable()
> > is called, and local irq is kept disabled, so the local_irq_disable()
> > at the end of these two functions are not necessary, remove it.
>
> Could I put the patch in your patch tracking system?

Yes please. Thanks.

--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.