2016-10-03 09:25:17

by Peter Zijlstra

[permalink] [raw]
Subject: [RFC][PATCH 0/4] FUTEX_UNLOCK_PI wobbles


Hi,

During my last PI failing patch set it became obvious there's a number of
related fail in FUTEX_UNLOCK_PI that needed sorting before we can move on
with that stuff.

These here patches are the result of staring at that code for a wee bit.

Please have a very _very_ careful look at the last patch, it appears to not
explode when running:

- perf bench futex lock-pi
- selftests/futex

but given the immense amount of tricky involved with both PI and futex there is
bound to be something I've overlooked.

Do people have more/better futex-pi test cases?


2016-10-05 01:02:29

by Davidlohr Bueso

[permalink] [raw]
Subject: Re: [RFC][PATCH 0/4] FUTEX_UNLOCK_PI wobbles

On Mon, 03 Oct 2016, Peter Zijlstra wrote:

>
>Hi,
>
>During my last PI failing patch set it became obvious there's a number of
>related fail in FUTEX_UNLOCK_PI that needed sorting before we can move on
>with that stuff.
>
>These here patches are the result of staring at that code for a wee bit.
>
>Please have a very _very_ careful look at the last patch, it appears to not
>explode when running:
>
> - perf bench futex lock-pi
> - selftests/futex
>
>but given the immense amount of tricky involved with both PI and futex there is
>bound to be something I've overlooked.
>
>Do people have more/better futex-pi test cases?

pi_stress.

2016-10-05 06:21:08

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [RFC][PATCH 0/4] FUTEX_UNLOCK_PI wobbles

On Tue, Oct 04, 2016 at 06:02:14PM -0700, Davidlohr Bueso wrote:
> On Mon, 03 Oct 2016, Peter Zijlstra wrote:

> >Do people have more/better futex-pi test cases?
>
> pi_stress.

Where does one find that? Link?

Subject: Re: [RFC][PATCH 0/4] FUTEX_UNLOCK_PI wobbles

On 2016-10-05 08:20:58 [+0200], Peter Zijlstra wrote:
> > pi_stress.
>
> Where does one find that? Link?
https://git.kernel.org/cgit/utils/rt-tests/rt-tests.git/tree/src/pi_tests/pi_stress.c

Take the whole package :)

Sebastian

2016-10-05 16:04:57

by Davidlohr Bueso

[permalink] [raw]
Subject: Re: [RFC][PATCH 0/4] FUTEX_UNLOCK_PI wobbles

On Wed, 05 Oct 2016, Peter Zijlstra wrote:

>On Tue, Oct 04, 2016 at 06:02:14PM -0700, Davidlohr Bueso wrote:
>> On Mon, 03 Oct 2016, Peter Zijlstra wrote:
>
>> >Do people have more/better futex-pi test cases?
>>
>> pi_stress.
>
>Where does one find that? Link?

Sorry, git://git.kernel.org/pub/scm/linux/kernel/git/clrkwllms/rt-tests.git