2016-10-10 15:25:41

by Ming Lei

Subject: [PATCH] SCSI: remove one useless stack variable

The local variable of 'devname' in scsi_report_lun_scan()
isn't used any more, so remove it.

Cc: Christoph Hellwig <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
---
drivers/scsi/scsi_scan.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index bb9b58e21d95..6f7128f49c30 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1307,7 +1307,6 @@ static void scsi_sequential_lun_scan(struct scsi_target *starget,
static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
enum scsi_scan_mode rescan)
{
- char devname[64];
unsigned char scsi_cmd[MAX_COMMAND_SIZE];
unsigned int length;
u64 lun;
@@ -1349,9 +1348,6 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
}
}

- sprintf(devname, "host %d channel %d id %d",
- shost->host_no, sdev->channel, sdev->id);
-
/*
* Allocate enough to hold the header (the same size as one scsi_lun)
* plus the number of luns we are requesting. 511 was the default
--
2.7.4

2016-10-10 16:51:56

by Christoph Hellwig

Subject: Re: [PATCH] SCSI: remove one useless stack variable

On Mon, Oct 10, 2016 at 11:25:33PM +0800, Ming Lei wrote:
> The local variable of 'devname' in scsi_report_lun_scan()
> isn't used any more, so remove it.

Looks fine,

Reviewed-by: Christoph Hellwig <[email protected]>

2016-10-11 23:24:18

by Martin K. Petersen

Subject: Re: [PATCH] SCSI: remove one useless stack variable

>>>>> "Ming" == Ming Lei <[email protected]> writes:

Ming> The local variable of 'devname' in scsi_report_lun_scan() isn't
Ming> used any more, so remove it.

Applied to 4.9/scsi-fixes.

--
Martin K. Petersen Oracle Linux Engineering