2016-10-11 19:50:48

by Nadim Almas

[permalink] [raw]
Subject: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

fixed trailing */ Block comments and 80 character line limit coding style issue

Signed-off-by: Nadim Almas <[email protected]>
---


drivers/staging/greybus/arche-apb-ctrl.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
index 70323aa..eeba912 100644
--- a/drivers/staging/greybus/arche-apb-ctrl.c
+++ b/drivers/staging/greybus/arche-apb-ctrl.c
@@ -168,7 +168,10 @@ static int standby_boot_seq(struct platform_device *pdev)
if (apb->init_disabled)
return 0;

- /* Even if it is in OFF state, then we do not want to change the state */
+ /*
+ * Even if it is in OFF state,
+ * then we do not want to change the state
+ */
if (apb->state == ARCHE_PLATFORM_STATE_STANDBY ||
apb->state == ARCHE_PLATFORM_STATE_OFF)
return 0;
@@ -183,7 +186,7 @@ static int standby_boot_seq(struct platform_device *pdev)
* Pasted from WDM spec,
* - A falling edge on POWEROFF_L is detected (a)
* - WDM enters standby mode, but no output signals are changed
- * */
+ */

/* TODO: POWEROFF_L is input to WDM module */
apb->state = ARCHE_PLATFORM_STATE_STANDBY;
@@ -286,7 +289,8 @@ static ssize_t state_store(struct device *dev,
return count;

/* First we want to make sure we power off everything
- * and then enter FW flashing state */
+ * and then enter FW flashing state
+ */
poweroff_seq(pdev);
ret = fw_flashing_seq(pdev);
} else {
--
2.7.4


2016-10-12 13:25:47

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

On Tue, Oct 11, 2016 at 12:49:54PM -0700, Nadim Almas wrote:
> fixed trailing */ Block comments and 80 character line limit coding style issue
>
> Signed-off-by: Nadim Almas <[email protected]>
> ---

Someone else already sent this same patch in before you, sorry :(

2016-10-12 14:18:05

by Nadim Almas

[permalink] [raw]
Subject: Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

>Someone else already sent this same patch in before you, sorry
But sir how can i come to know that Someone else already sent
particular patch before sending that particular patch

On Wed, Oct 12, 2016 at 6:55 PM, Greg KH <[email protected]> wrote:
> On Tue, Oct 11, 2016 at 12:49:54PM -0700, Nadim Almas wrote:
>> fixed trailing */ Block comments and 80 character line limit coding style issue
>>
>> Signed-off-by: Nadim Almas <[email protected]>
>> ---
>
> Someone else already sent this same patch in before you, sorry :(

2016-10-12 14:45:54

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

On Wed, Oct 12, 2016 at 07:33:07PM +0530, Nadim Almas wrote:
> >Someone else already sent this same patch in before you, sorry
> But sir how can i come to know that Someone else already sent
> particular patch before sending that particular patch

You can subscribe to the driverdev mailing list to see what othes are
working on, and you can follow my staging-testing kernel branch in the
staging.git tree. But sometimes you just get unlucky, lots of people
are working on cleaning up staging drivers, people do the same work at
the same time quite often, it's just part of the process.

Pick something else to work on, we have lots of things to do :)

thanks,

greg k-h

2016-10-13 04:01:09

by Alexander Alemayhu

[permalink] [raw]
Subject: Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

On Wed, Oct 12, 2016 at 04:45:54PM +0200, Greg KH wrote:
>
> You can subscribe to the driverdev mailing list to see what othes are
> working on, and you can follow my staging-testing kernel branch in the
> staging.git tree. But sometimes you just get unlucky, lots of people
> are working on cleaning up staging drivers, people do the same work at
> the same time quite often, it's just part of the process.
>

Is this
(http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel)
the right page for subscribing?

Thanks.

2016-10-13 07:16:16

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

On Thu, Oct 13, 2016 at 06:00:45AM +0200, Alexander Alemayhu wrote:
> On Wed, Oct 12, 2016 at 04:45:54PM +0200, Greg KH wrote:
> >
> > You can subscribe to the driverdev mailing list to see what othes are
> > working on, and you can follow my staging-testing kernel branch in the
> > staging.git tree. But sometimes you just get unlucky, lots of people
> > are working on cleaning up staging drivers, people do the same work at
> > the same time quite often, it's just part of the process.
> >
>
> Is this
> (http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel)
> the right page for subscribing?

Yes.

greg k-h