2016-10-12 02:40:41

by Viresh Kumar

Subject: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

Some of the print messages are using the incorrect device pointer, fix
them.

Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/staging/greybus/gpio.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 5e06e4229e42..250caa00de5e 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
ret = gb_gpio_irqchip_add(gpio, irqc, 0,
handle_level_irq, IRQ_TYPE_NONE);
if (ret) {
- dev_err(&connection->bundle->dev,
- "failed to add irq chip: %d\n", ret);
+ dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
goto exit_line_free;
}

ret = gpiochip_add(gpio);
if (ret) {
- dev_err(&connection->bundle->dev,
- "failed to add gpio chip: %d\n", ret);
+ dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
goto exit_gpio_irqchip_remove;
}

--
2.7.1.410.g6faf27b

2016-10-12 02:40:38

by Viresh Kumar

Subject: [PATCH 2/2] Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev

Some of the print messages are using the incorrect device pointer, fix
them.

Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/staging/greybus/uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 5ee7954bd9f9..2633d2bfb1b4 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -888,7 +888,7 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
minor = alloc_minor(gb_tty);
if (minor < 0) {
if (minor == -ENOSPC) {
- dev_err(&connection->bundle->dev,
+ dev_err(&gbphy_dev->dev,
"no more free minor numbers\n");
retval = -ENODEV;
} else {
--
2.7.1.410.g6faf27b

2016-10-13 14:21:06

by Rui Miguel Silva

Subject: Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

Hi Viresh,
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
>Some of the print messages are using the incorrect device pointer, fix
>them.
>
>Signed-off-by: Viresh Kumar <[email protected]>

Reviewed-by: Rui Miguel Silva <[email protected]>

Thanks,
Rui
>---
> drivers/staging/greybus/gpio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
>index 5e06e4229e42..250caa00de5e 100644
>--- a/drivers/staging/greybus/gpio.c
>+++ b/drivers/staging/greybus/gpio.c
>@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
> ret = gb_gpio_irqchip_add(gpio, irqc, 0,
> handle_level_irq, IRQ_TYPE_NONE);
> if (ret) {
>- dev_err(&connection->bundle->dev,
>- "failed to add irq chip: %d\n", ret);
>+ dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
> goto exit_line_free;
> }
>
> ret = gpiochip_add(gpio);
> if (ret) {
>- dev_err(&connection->bundle->dev,
>- "failed to add gpio chip: %d\n", ret);
>+ dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
> goto exit_gpio_irqchip_remove;
> }
>
>--
>2.7.1.410.g6faf27b
>

2016-10-15 11:18:56

by Johan Hovold

Subject: Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
> Some of the print messages are using the incorrect device pointer, fix
> them.
>
> Signed-off-by: Viresh Kumar <[email protected]>

Acked-by: Johan Hovold <[email protected]>

2016-10-15 11:21:59

by Johan Hovold

Subject: Re: [PATCH 2/2] Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev

On Wed, Oct 12, 2016 at 08:02:22AM +0530, Viresh Kumar wrote:
> Some of the print messages are using the incorrect device pointer, fix
> them.
>
> Signed-off-by: Viresh Kumar <[email protected]>

Acked-by: Johan Hovold <[email protected]>