2016-10-21 13:29:56

by Nadim Almas

Subject: [PATCH] Staging:wilc1000:host_interface: fixed 80 character line limit coding style issue

Fixed coding style issue

Signed-off-by: Nadim Almas <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 0c5dea7..6e6540f 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -497,10 +497,12 @@ static void handle_cfg_param(struct wilc_vif *vif,
if (cfg_param_attr->flag & POWER_MANAGEMENT) {
if (cfg_param_attr->power_mgmt_mode < 5) {
wid_list[i].id = WID_POWER_MANAGEMENT;
- wid_list[i].val = (s8 *)&cfg_param_attr->power_mgmt_mode;
+ wid_list[i].val = (s8 *)&cfg_param_attr->
+ power_mgmt_mode;
wid_list[i].type = WID_CHAR;
wid_list[i].size = sizeof(char);
- hif_drv->cfg_values.power_mgmt_mode = (u8)cfg_param_attr->power_mgmt_mode;
+ hif_drv->cfg_values.power_mgmt_mode =
+ (u8)cfg_param_attr->power_mgmt_mode;
} else {
netdev_err(vif->ndev, "Invalid power mode\n");
goto unlock;
--
2.7.4

2016-10-24 10:59:01

by Dan Carpenter

Subject: Re: [PATCH] Staging:wilc1000:host_interface: fixed 80 character line limit coding style issue

On Fri, Oct 21, 2016 at 06:59:39PM +0530, Nadim Almas wrote:
> Fixed coding style issue
>
> Signed-off-by: Nadim Almas <[email protected]>
> ---
> drivers/staging/wilc1000/host_interface.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 0c5dea7..6e6540f 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -497,10 +497,12 @@ static void handle_cfg_param(struct wilc_vif *vif,
> if (cfg_param_attr->flag & POWER_MANAGEMENT) {
> if (cfg_param_attr->power_mgmt_mode < 5) {
> wid_list[i].id = WID_POWER_MANAGEMENT;
> - wid_list[i].val = (s8 *)&cfg_param_attr->power_mgmt_mode;
> + wid_list[i].val = (s8 *)&cfg_param_attr->
> + power_mgmt_mode;

The original was easier to read.

regards,
dan carpenter