2016-10-24 12:42:44

by Stefan Richter

Subject: [PATCH net-next] ethernet: fix min/max MTU typos

Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
CC: Jarod Wilson <[email protected]>
CC: Thomas Falcon <[email protected]>
Signed-off-by: Stefan Richter <[email protected]>
---
drivers/net/ethernet/broadcom/sb1250-mac.c | 2 +-
drivers/net/ethernet/ibm/ibmveth.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c
index cb312e4c89f4..435a2e4739d1 100644
--- a/drivers/net/ethernet/broadcom/sb1250-mac.c
+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
@@ -2219,7 +2219,7 @@ static int sbmac_init(struct platform_device *pldev, long long base)

dev->netdev_ops = &sbmac_netdev_ops;
dev->watchdog_timeo = TX_TIMEOUT;
- dev->max_mtu = 0;
+ dev->min_mtu = 0;
dev->max_mtu = ENET_PACKET_SIZE;

netif_napi_add(dev, &sc->napi, sbmac_poll, 16);
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 29c05d0d79a9..4a81c892fc31 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1549,7 +1549,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
}

netdev->min_mtu = IBMVETH_MIN_MTU;
- netdev->min_mtu = ETH_MAX_MTU;
+ netdev->max_mtu = ETH_MAX_MTU;

memcpy(netdev->dev_addr, mac_addr_p, ETH_ALEN);

--
Stefan Richter
-======----- =-=- ==---
http://arcgraph.de/sr/

2016-10-25 03:07:32

by Jarod Wilson

Subject: Re: [PATCH net-next] ethernet: fix min/max MTU typos

On Mon, Oct 24, 2016 at 02:42:26PM +0200, Stefan Richter wrote:
> Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
> CC: Jarod Wilson <[email protected]>
> CC: Thomas Falcon <[email protected]>
> Signed-off-by: Stefan Richter <[email protected]>

Wuf. Thank you, Stefan. Way too many bleeding eyeball hours staring at all
those changes.

Acked-by: Jarod Wilson <[email protected]>

--
Jarod Wilson
[email protected]

2016-10-27 20:19:12

by David Miller

Subject: Re: [PATCH net-next] ethernet: fix min/max MTU typos

From: Stefan Richter <[email protected]>
Date: Mon, 24 Oct 2016 14:42:26 +0200

> Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
> CC: Jarod Wilson <[email protected]>
> CC: Thomas Falcon <[email protected]>
> Signed-off-by: Stefan Richter <[email protected]>

Applied.