2016-10-25 19:21:22

by Paul Kocialkowski

Subject: [PATCH] iio: si7020: Add devicetree support and trivial bindings

This adds devicetree support for the si7020 iio driver. Since it works
well without requiring any additional property, its compatible string is
added to the trivial i2c devices bindings list.

Signed-off-by: Paul Kocialkowski <[email protected]>
---
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
drivers/iio/humidity/si7020.c | 11 ++++++++++-
2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index 5c70ce9..6afba26 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -145,6 +145,7 @@ ricoh,rv5c387a I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
samsung,24ad0xd1 S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
sgx,vz89x SGX Sensortech VZ89X Sensors
sii,s35390a 2-wire CMOS real-time clock
+silabs,si7020 Relative Humidity and Temperature Sensors
skyworks,sky81452 Skyworks SKY81452: Six-Channel White LED Driver with Touch Panel Bias Supply
st,24c256 i2c serial eeprom (24cxx)
st,m41t00 Serial real-time clock (RTC)
diff --git a/drivers/iio/humidity/si7020.c b/drivers/iio/humidity/si7020.c
index ffc2ccf..345a765 100644
--- a/drivers/iio/humidity/si7020.c
+++ b/drivers/iio/humidity/si7020.c
@@ -154,8 +154,17 @@ static const struct i2c_device_id si7020_id[] = {
};
MODULE_DEVICE_TABLE(i2c, si7020_id);

+static const struct of_device_id si7020_dt_ids[] = {
+ { .compatible = "silabs,si7020" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, si7020_dt_ids);
+
static struct i2c_driver si7020_driver = {
- .driver.name = "si7020",
+ .driver = {
+ .name = "si7020",
+ .of_match_table = of_match_ptr(si7020_dt_ids),
+ },
.probe = si7020_probe,
.id_table = si7020_id,
};
--
2.10.0

2016-10-30 16:30:13

by Jonathan Cameron

Subject: Re: [PATCH] iio: si7020: Add devicetree support and trivial bindings

On 25/10/16 20:20, Paul Kocialkowski wrote:
> This adds devicetree support for the si7020 iio driver. Since it works
> well without requiring any additional property, its compatible string is
> added to the trivial i2c devices bindings list.
>
> Signed-off-by: Paul Kocialkowski <[email protected]>
Applied to the togreg branch of iio.git - initially pushed out as tesitng
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
> drivers/iio/humidity/si7020.c | 11 ++++++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> index 5c70ce9..6afba26 100644
> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> @@ -145,6 +145,7 @@ ricoh,rv5c387a I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> samsung,24ad0xd1 S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
> sgx,vz89x SGX Sensortech VZ89X Sensors
> sii,s35390a 2-wire CMOS real-time clock
> +silabs,si7020 Relative Humidity and Temperature Sensors
> skyworks,sky81452 Skyworks SKY81452: Six-Channel White LED Driver with Touch Panel Bias Supply
> st,24c256 i2c serial eeprom (24cxx)
> st,m41t00 Serial real-time clock (RTC)
> diff --git a/drivers/iio/humidity/si7020.c b/drivers/iio/humidity/si7020.c
> index ffc2ccf..345a765 100644
> --- a/drivers/iio/humidity/si7020.c
> +++ b/drivers/iio/humidity/si7020.c
> @@ -154,8 +154,17 @@ static const struct i2c_device_id si7020_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, si7020_id);
>
> +static const struct of_device_id si7020_dt_ids[] = {
> + { .compatible = "silabs,si7020" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, si7020_dt_ids);
> +
> static struct i2c_driver si7020_driver = {
> - .driver.name = "si7020",
> + .driver = {
> + .name = "si7020",
> + .of_match_table = of_match_ptr(si7020_dt_ids),
> + },
> .probe = si7020_probe,
> .id_table = si7020_id,
> };
>

2016-10-31 03:09:43

by Rob Herring (Arm)

Subject: Re: [PATCH] iio: si7020: Add devicetree support and trivial bindings

On Tue, Oct 25, 2016 at 09:20:10PM +0200, Paul Kocialkowski wrote:
> This adds devicetree support for the si7020 iio driver. Since it works
> well without requiring any additional property, its compatible string is
> added to the trivial i2c devices bindings list.
>
> Signed-off-by: Paul Kocialkowski <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
> drivers/iio/humidity/si7020.c | 11 ++++++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <[email protected]>