2016-10-29 08:12:29

by Ming Lei

Subject: [PATCH 05/60] target: avoid to access .bi_vcnt directly

When the bio is full, bio_add_pc_page() will return zero,
so use this way to handle full bio.

Also replace access to .bi_vcnt for pr_debug() with bio_segments().

Signed-off-by: Ming Lei <[email protected]>
---
drivers/target/target_core_pscsi.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index 9125d9358dea..04d7aa7390d0 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -935,13 +935,9 @@ pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,

rc = bio_add_pc_page(pdv->pdv_sd->request_queue,
bio, page, bytes, off);
- if (rc != bytes)
- goto fail;
-
pr_debug("PSCSI: bio->bi_vcnt: %d nr_vecs: %d\n",
- bio->bi_vcnt, nr_vecs);
-
- if (bio->bi_vcnt > nr_vecs) {
+ bio_segments(bio), nr_vecs);
+ if (rc != bytes) {
pr_debug("PSCSI: Reached bio->bi_vcnt max:"
" %d i: %d bio: %p, allocating another"
" bio\n", bio->bi_vcnt, i, bio);
--
2.7.4

2016-10-31 15:26:47

by Christoph Hellwig

Subject: Re: [PATCH 05/60] target: avoid to access .bi_vcnt directly

On Sat, Oct 29, 2016 at 04:08:04PM +0800, Ming Lei wrote:
> When the bio is full, bio_add_pc_page() will return zero,
> so use this way to handle full bio.
>
> Also replace access to .bi_vcnt for pr_debug() with bio_segments().
>
> Signed-off-by: Ming Lei <[email protected]>

Looks fine,

Reviewed-by: Christoph Hellwig <[email protected]>