2016-11-04 20:35:19

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH 10/10] clk: ti: make clk-dra7-atl explicitly non-modular

On 07/04, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> arch/arm/mach-omap2/Kconfig:config SOC_DRA7XX
> arch/arm/mach-omap2/Kconfig: bool "TI DRA7XX"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tags etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Tero Kristo <[email protected]>
> Cc: Michael Turquette <[email protected]>
> Cc: Peter Ujfalusi <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Paul Gortmaker <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project