2016-11-07 19:06:10

by Nicholas Hanley

Subject: [PATCH] staging: lustre: o2iblnd: use bool assignment to true/false

Replace 0 with false in tx_pages_mapped = 0 to be consistent with
the rest of the lustre code.

Signed-off-by: Nicholas Hanley <[email protected]>
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
index 13235b0..e2fc65f 100644
--- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
+++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
@@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
{
__u64 *pages = tx->tx_pages;
bool is_rx = (rd != tx->tx_rd);
- bool tx_pages_mapped = 0;
+ bool tx_pages_mapped = false;
struct kib_fmr_pool *fpo;
int npages = 0;
__u64 version;
--
2.10.2

2016-11-07 21:20:34

by Dilger, Andreas

Subject: Re: [PATCH] staging: lustre: o2iblnd: use bool assignment to true/false

On Nov 7, 2016, at 12:01, Nicholas Hanley <[email protected]> wrote:
>
> Replace 0 with false in tx_pages_mapped = 0 to be consistent with
> the rest of the lustre code.
>
> Signed-off-by: Nicholas Hanley <[email protected]>

Reviewed-by: Andreas Dilger <[email protected]>

> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> index 13235b0..e2fc65f 100644
> --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> {
> __u64 *pages = tx->tx_pages;
> bool is_rx = (rd != tx->tx_rd);
> - bool tx_pages_mapped = 0;
> + bool tx_pages_mapped = false;
> struct kib_fmr_pool *fpo;
> int npages = 0;
> __u64 version;
> --
> 2.10.2
>