2016-10-25 19:29:49: Changes V3:
* fix property name to enable twl6040 jack-detection and not jack_detection (Peter Ujfalusi)
* fix typo on bindings documentation
* fix typos in commit messages (Tony Lindgren)
2016-10-25 18:48:28: This patch series adds DT nodes for:
* twl6040 enable jack_detection (e.g. OMAP5EVM)
* twl6037 gpadc for omap5 based boards (e.g. OMAP5EVM)
H. Nikolaus Schaller (3):
dts: omap5: board-common: add phandle to reference Palmas gpadc
dts: omap5: board-common: enable twl6040 headset jack detection
ASoC: omap-abe-twl6040: fix typo in bindings documentation
Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt | 2 +-
arch/arm/boot/dts/omap5-board-common.dtsi | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
--
2.7.3
Signed-off-by: H. Nikolaus Schaller <[email protected]>
---
arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index b04adee..ab60a8e 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi
@@ -124,6 +124,7 @@
compatible = "ti,abe-twl6040";
ti,model = "omap5-uevm";
+ ti,jack-detection;
ti,mclk-freq = <19200000>;
ti,mcpdm = <&mcpdm>;
--
2.7.3
Will be needed for iio based drivers.
Signed-off-by: H. Nikolaus Schaller <[email protected]>
---
arch/arm/boot/dts/omap5-board-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index 7500283..b04adee 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi
@@ -415,7 +415,7 @@
ti,backup-battery-charge-high-current;
};
- gpadc {
+ gpadc: gpadc {
compatible = "ti,palmas-gpadc";
interrupts = <18 0
16 0
--
2.7.3
Signed-off-by: H. Nikolaus Schaller <[email protected]>
---
Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt b/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt
index fd40c85..462b04e8 100644
--- a/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt
+++ b/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt
@@ -12,7 +12,7 @@ Required properties:
Optional properties:
- ti,dmic: phandle for the OMAP dmic node if the machine have it connected
-- ti,jack_detection: Need to be present if the board capable to detect jack
+- ti,jack-detection: Need to be present if the board capable to detect jack
insertion, removal.
Available audio endpoints for the audio-routing table:
--
2.7.3
On 10/25/16 20:38, H. Nikolaus Schaller wrote:
> Signed-off-by: H. Nikolaus Schaller <[email protected]>
Acked-by: Peter Ujfalusi <[email protected]>
> ---
> Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt b/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt
> index fd40c85..462b04e8 100644
> --- a/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt
> +++ b/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt
> @@ -12,7 +12,7 @@ Required properties:
>
> Optional properties:
> - ti,dmic: phandle for the OMAP dmic node if the machine have it connected
> -- ti,jack_detection: Need to be present if the board capable to detect jack
> +- ti,jack-detection: Need to be present if the board capable to detect jack
> insertion, removal.
>
> Available audio endpoints for the audio-routing table:
>
--
Péter
On 10/25/16 20:38, H. Nikolaus Schaller wrote:
> Signed-off-by: H. Nikolaus Schaller <[email protected]>
I'm not sure if this is valid for igep0500 as I have not seen the schematics.
It might be safer to enable the jack detection only for omap5-uevm?
In any case:
Reviewed-by: Peter Ujfalusi <[email protected]>
> ---
> arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> index b04adee..ab60a8e 100644
> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> @@ -124,6 +124,7 @@
> compatible = "ti,abe-twl6040";
> ti,model = "omap5-uevm";
>
> + ti,jack-detection;
> ti,mclk-freq = <19200000>;
>
> ti,mcpdm = <&mcpdm>;
>
--
Péter
* Peter Ujfalusi <[email protected]> [161026 01:03]:
> On 10/25/16 20:38, H. Nikolaus Schaller wrote:
> > Signed-off-by: H. Nikolaus Schaller <[email protected]>
>
> I'm not sure if this is valid for igep0500 as I have not seen the schematics.
> It might be safer to enable the jack detection only for omap5-uevm?
FYI it's pretty much the same design and audio worked fine on igepv5
the last time I tested it. I guess a good reason to drill a new hole
to my pi-top case for the audio jack :)
Tony
On Tue, Oct 25, 2016 at 07:38:11PM +0200, H. Nikolaus Schaller wrote:
> Signed-off-by: H. Nikolaus Schaller <[email protected]>
> ---
> Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <[email protected]>
* Rob Herring <[email protected]> [161030 20:08]:
> On Tue, Oct 25, 2016 at 07:38:11PM +0200, H. Nikolaus Schaller wrote:
> > Signed-off-by: H. Nikolaus Schaller <[email protected]>
> > ---
> > Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Rob Herring <[email protected]>
Applying all three into omap-for-v4.9/fixes so we can
avoid the typo getting used somewhere.
Regards,
Tony