2016-11-10 14:09:58

by Shiva Kerdel

Subject: [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

Follow the kernel type preferrences of using 's16' over 'int16_t'.

Signed-off-by: Shiva Kerdel <[email protected]>
Acked-by: Stuart Yoder <[email protected]>
---
drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
index e915574..c7cad87 100644
--- a/drivers/staging/fsl-mc/include/mc-bus.h
+++ b/drivers/staging/fsl-mc/include/mc-bus.h
@@ -42,8 +42,8 @@ struct msi_domain_info;
*/
struct fsl_mc_resource_pool {
enum fsl_mc_pool_type type;
- int16_t max_count;
- int16_t free_count;
+ s16 max_count;
+ s16 free_count;
struct mutex mutex; /* serializes access to free_list */
struct list_head free_list;
struct fsl_mc_bus *mc_bus;
--
2.10.2

2016-11-10 14:10:00

by Shiva Kerdel

Subject: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

Follow the kernel type preferrences of using 's32' over 'int32_t'.

Signed-off-by: Shiva Kerdel <[email protected]>
Acked-by: Stuart Yoder <[email protected]>
---
drivers/staging/fsl-mc/include/mc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
index a781a36..1c46c0c 100644
--- a/drivers/staging/fsl-mc/include/mc.h
+++ b/drivers/staging/fsl-mc/include/mc.h
@@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
*/
struct fsl_mc_resource {
enum fsl_mc_pool_type type;
- int32_t id;
+ s32 id;
void *data;
struct fsl_mc_resource_pool *parent_pool;
struct list_head node;
--
2.10.2

2016-11-10 14:20:33

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

On Thu, Nov 10, 2016 at 03:09:07PM +0100, Shiva Kerdel wrote:
> Follow the kernel type preferrences of using 's16' over 'int16_t'.
>
> Signed-off-by: Shiva Kerdel <[email protected]>
> Acked-by: Stuart Yoder <[email protected]>
> ---
> drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

You forgot to put, below the --- line, what changed from v1 to v2 :(

third time is a charm?

thanks,

greg k-h

2016-11-10 14:31:53

by Shiva Kerdel

Subject: Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

I corrected the log message because I wrote 's32' instead of 's16' in
this patch (confused with the other one that I sent too).

Thank you for your guidance,

Shiva Kerdel

On 11/10/16 15:20, Greg KH wrote:
> On Thu, Nov 10, 2016 at 03:09:07PM +0100, Shiva Kerdel wrote:
>> Follow the kernel type preferrences of using 's16' over 'int16_t'.
>>
>> Signed-off-by: Shiva Kerdel <[email protected]>
>> Acked-by: Stuart Yoder <[email protected]>
>> ---
>> drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> You forgot to put, below the --- line, what changed from v1 to v2 :(
>
> third time is a charm?
>
> thanks,
>
> greg k-h