Removing struct sk_buff *skb from capi.c
The Coccinelle semantic patch used to make this change is as follows:
@@
type T;
identifier D;
@@
- T D;
...when != D
Signed-off-by: Nadim Almas <[email protected]>
---
drivers/staging/i4l/act2000/capi.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/i4l/act2000/capi.c b/drivers/staging/i4l/act2000/capi.c
index 61386a7..2c2c77e 100644
--- a/drivers/staging/i4l/act2000/capi.c
+++ b/drivers/staging/i4l/act2000/capi.c
@@ -183,7 +183,6 @@ static void
actcapi_connect_b3_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(17, 0x82, 0x00);
ACTCAPI_CHKSKB;
@@ -304,7 +303,6 @@ void
actcapi_select_b2_protocol_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(10, 0x40, 0x00);
ACTCAPI_CHKSKB;
@@ -339,7 +337,6 @@ static void
actcapi_select_b3_protocol_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(17, 0x80, 0x00);
ACTCAPI_CHKSKB;
@@ -360,7 +357,6 @@ static void
actcapi_listen_b3_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x81, 0x00);
ACTCAPI_CHKSKB;
@@ -372,7 +368,6 @@ static void
actcapi_disconnect_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(3, 0x04, 0x00);
ACTCAPI_CHKSKB;
@@ -385,7 +380,6 @@ void
actcapi_disconnect_b3_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(17, 0x84, 0x00);
ACTCAPI_CHKSKB;
@@ -402,7 +396,6 @@ void
actcapi_connect_resp(act2000_card *card, act2000_chan *chan, __u8 cause)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(3, 0x02, 0x03);
ACTCAPI_CHKSKB;
@@ -420,7 +413,6 @@ static void
actcapi_connect_active_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x03, 0x03);
ACTCAPI_CHKSKB;
@@ -434,7 +426,6 @@ static void
actcapi_connect_b3_resp(act2000_card *card, act2000_chan *chan, __u8 rejectcause)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR((rejectcause ? 3 : 17), 0x82, 0x03);
ACTCAPI_CHKSKB;
@@ -454,7 +445,6 @@ static void
actcapi_connect_b3_active_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x83, 0x03);
ACTCAPI_CHKSKB;
@@ -467,7 +457,6 @@ static void
actcapi_info_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x07, 0x03);
ACTCAPI_CHKSKB;
@@ -479,7 +468,6 @@ static void
actcapi_disconnect_b3_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x84, 0x03);
ACTCAPI_CHKSKB;
@@ -493,7 +481,6 @@ static void
actcapi_disconnect_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x04, 0x03);
ACTCAPI_CHKSKB;
--
2.7.4
Hi Nadim,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.9-rc4 next-20161111]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Nadim-Almas/Staging-i4l-act2000-capi-Removing-necessary-variable/20161111-180529
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_connect_b3_req':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
>> drivers/staging/i4l/act2000/capi.c:187:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(17, 0x82, 0x00);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c:108:3: note: each undeclared identifier is reported only once for each function it appears in
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
>> drivers/staging/i4l/act2000/capi.c:187:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(17, 0x82, 0x00);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_select_b2_protocol_req':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:307:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(10, 0x40, 0x00);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_select_b3_protocol_req':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:341:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(17, 0x80, 0x00);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_listen_b3_req':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:361:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(2, 0x81, 0x00);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_disconnect_req':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:372:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(3, 0x04, 0x00);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_disconnect_b3_req':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:384:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(17, 0x84, 0x00);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_connect_resp':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:400:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(3, 0x02, 0x03);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_connect_active_resp':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:417:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(2, 0x03, 0x03);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_connect_b3_resp':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:430:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR((rejectcause ? 3 : 17), 0x82, 0x03);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_connect_b3_active_resp':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:449:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(2, 0x83, 0x03);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_info_resp':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:461:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(2, 0x07, 0x03);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_disconnect_b3_resp':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:472:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(2, 0x84, 0x03);
^~~~~~~~~~~~~
drivers/staging/i4l/act2000/capi.c: In function 'actcapi_disconnect_resp':
>> drivers/staging/i4l/act2000/capi.c:108:3: error: 'skb' undeclared (first use in this function)
skb = alloc_skb(l + 8, GFP_ATOMIC); \
^
drivers/staging/i4l/act2000/capi.c:485:2: note: in expansion of macro 'ACTCAPI_MKHDR'
ACTCAPI_MKHDR(2, 0x04, 0x03);
^~~~~~~~~~~~~
vim +/skb +108 drivers/staging/i4l/act2000/capi.c
06d1f85e drivers/staging/i4l/act2000/capi.c Elizabeth Ferdman 2016-10-09 102 return i ? 1 : 2;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 103 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 104 return 0;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 105 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 106
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 107 #define ACTCAPI_MKHDR(l, c, s) { \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 @108 skb = alloc_skb(l + 8, GFP_ATOMIC); \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 109 if (skb) { \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 110 m = (actcapi_msg *)skb_put(skb, l + 8); \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 111 m->hdr.len = l + 8; \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 112 m->hdr.applicationID = 1; \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 113 m->hdr.cmd.cmd = c; \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 114 m->hdr.cmd.subcmd = s; \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 115 m->hdr.msgnum = actcapi_nextsmsg(card); \
5d2b7c4a drivers/staging/i4l/act2000/capi.c Anson Jacob 2016-08-26 116 } else { \
5d2b7c4a drivers/staging/i4l/act2000/capi.c Anson Jacob 2016-08-26 117 m = NULL; \
5d2b7c4a drivers/staging/i4l/act2000/capi.c Anson Jacob 2016-08-26 118 } \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 119 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 120
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 121 #define ACTCAPI_CHKSKB if (!skb) { \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 122 printk(KERN_WARNING "actcapi: alloc_skb failed\n"); \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 123 return; \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 124 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 125
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 126 #define ACTCAPI_QUEUE_TX { \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 127 actcapi_debug_msg(skb, 1); \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 128 skb_queue_tail(&card->sndq, skb); \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 129 act2000_schedule_tx(card); \
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 130 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 131
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 132 int
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 133 actcapi_listen_req(act2000_card *card)
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 134 {
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 135 __u16 eazmask = 0;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 136 int i;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 137 actcapi_msg *m;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 138 struct sk_buff *skb;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 139
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 140 for (i = 0; i < ACT2000_BCH; i++)
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 141 eazmask |= card->bch[i].eazmask;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 142 ACTCAPI_MKHDR(9, 0x05, 0x00);
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 143 if (!skb) {
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 144 printk(KERN_WARNING "actcapi: alloc_skb failed\n");
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 145 return -ENOMEM;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 146 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 147 m->msg.listen_req.controller = 0;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 148 m->msg.listen_req.infomask = 0x3f; /* All information */
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 149 m->msg.listen_req.eazmask = eazmask;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 150 m->msg.listen_req.simask = (eazmask) ? 0x86 : 0; /* All SI's */
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 151 ACTCAPI_QUEUE_TX;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 152 return 0;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 153 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 154
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 155 int
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 156 actcapi_connect_req(act2000_card *card, act2000_chan *chan, char *phone,
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 157 char eaz, int si1, int si2)
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 158 {
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 159 actcapi_msg *m;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 160 struct sk_buff *skb;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 161
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 162 ACTCAPI_MKHDR((11 + strlen(phone)), 0x02, 0x00);
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 163 if (!skb) {
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 164 printk(KERN_WARNING "actcapi: alloc_skb failed\n");
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 165 chan->fsm_state = ACT2000_STATE_NULL;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 166 return -ENOMEM;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 167 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 168 m->msg.connect_req.controller = 0;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 169 m->msg.connect_req.bchan = 0x83;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 170 m->msg.connect_req.infomask = 0x3f;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 171 m->msg.connect_req.si1 = si1;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 172 m->msg.connect_req.si2 = si2;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 173 m->msg.connect_req.eaz = eaz ? eaz : '0';
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 174 m->msg.connect_req.addr.len = strlen(phone) + 1;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 175 m->msg.connect_req.addr.tnp = 0x81;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 176 memcpy(m->msg.connect_req.addr.num, phone, strlen(phone));
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 177 chan->callref = m->hdr.msgnum;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 178 ACTCAPI_QUEUE_TX;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 179 return 0;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 180 }
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 181
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 182 static void
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 183 actcapi_connect_b3_req(act2000_card *card, act2000_chan *chan)
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 184 {
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 185 actcapi_msg *m;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 186
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 @187 ACTCAPI_MKHDR(17, 0x82, 0x00);
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 188 ACTCAPI_CHKSKB;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 189 m->msg.connect_b3_req.plci = chan->plci;
^1da177e drivers/isdn/act2000/capi.c Linus Torvalds 2005-04-16 190 memset(&m->msg.connect_b3_req.ncpi, 0,
:::::: The code at line 108 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <[email protected]>
:::::: CC: Linus Torvalds <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Fri, Nov 11, 2016 at 03:28:21PM +0530, Nadim Almas wrote:
> Removing struct sk_buff *skb from capi.c
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> type T;
> identifier D;
> @@
> - T D;
> ...when != D
>
> Signed-off-by: Nadim Almas <[email protected]>
> ---
> drivers/staging/i4l/act2000/capi.c | 13 -------------
> 1 file changed, 13 deletions(-)
Why didn't you test build your patch :(
Please ALWAYS do so...
greg k-h