2016-11-14 09:08:06

by ho.jia.jie

[permalink] [raw]
Subject: [PATCH] net: ethernet: Fix SGMII unable to switch speed and autonego failure

From: Jia Jie Ho <[email protected]>

TSE PCS SGMII ethernet has an issue where switching speed doesn't work
caused by a faulty register macro offset. This fixes the issue.

Signed-off-by: Jia Jie Ho <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c b/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
index 2920e2e..489ef14 100644
--- a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
+++ b/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
@@ -63,8 +63,8 @@
#define TSE_PCS_SGMII_LINK_TIMER_0 0x0D40
#define TSE_PCS_SGMII_LINK_TIMER_1 0x0003
#define TSE_PCS_SW_RESET_TIMEOUT 100
-#define TSE_PCS_USE_SGMII_AN_MASK BIT(2)
-#define TSE_PCS_USE_SGMII_ENA BIT(1)
+#define TSE_PCS_USE_SGMII_AN_MASK BIT(1)
+#define TSE_PCS_USE_SGMII_ENA BIT(0)

#define SGMII_ADAPTER_CTRL_REG 0x00
#define SGMII_ADAPTER_DISABLE 0x0001
--
1.8.2.1


2016-11-15 17:06:44

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: ethernet: Fix SGMII unable to switch speed and autonego failure

From: [email protected]
Date: Mon, 14 Nov 2016 17:06:49 +0800

> From: Jia Jie Ho <[email protected]>
>
> TSE PCS SGMII ethernet has an issue where switching speed doesn't work
> caused by a faulty register macro offset. This fixes the issue.
>
> Signed-off-by: Jia Jie Ho <[email protected]>

Applied.