2016-11-19 17:47:06

by Quentin Lambert

Subject: [PATCH] isci: Add a missing call to pci_unmap_biosrom

Most error branches following the call to pci_map_biosrom contain
a call to pci_unmap_biosrom. This patch add these calls where
they are missing.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <[email protected]>

---
drivers/scsi/isci/probe_roms.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/scsi/isci/probe_roms.c
+++ b/drivers/scsi/isci/probe_roms.c
@@ -54,6 +54,7 @@ struct isci_orom *isci_request_oprom(str
len = pci_biosrom_size(pdev);
rom = devm_kzalloc(&pdev->dev, sizeof(*rom), GFP_KERNEL);
if (!rom) {
+ pci_unmap_biosrom(oprom);
dev_warn(&pdev->dev,
"Unable to allocate memory for orom\n");
return NULL;

2016-11-29 16:51:29

by Martin K. Petersen

Subject: Re: [PATCH] isci: Add a missing call to pci_unmap_biosrom

>>>>> "Quentin" == Quentin Lambert <[email protected]> writes:

Quentin> Most error branches following the call to pci_map_biosrom
Quentin> contain a call to pci_unmap_biosrom. This patch add these calls
Quentin> where they are missing.

Applied to 4.10/scsi-queue.

--
Martin K. Petersen Oracle Linux Engineering