2016-11-20 15:09:46

by Rafał Miłecki

Subject: [PATCH] mtd: bcm47xxpart: fix parsing first block after aligned TRX

From: Rafał Miłecki <[email protected]>

After parsing TRX we should skip to the first block placed behind it.
Our code was working only with TRX with length not aligned to the
blocksize. In other cases (length aligned) it was missing the block
places right after TRX.

This fixes calculation and simplifies the comment.

Signed-off-by: Rafał Miłecki <[email protected]>
---
drivers/mtd/bcm47xxpart.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/mtd/bcm47xxpart.c b/drivers/mtd/bcm47xxpart.c
index 3779475..283ff7e 100644
--- a/drivers/mtd/bcm47xxpart.c
+++ b/drivers/mtd/bcm47xxpart.c
@@ -229,12 +229,10 @@ static int bcm47xxpart_parse(struct mtd_info *master,

last_trx_part = curr_part - 1;

- /*
- * We have whole TRX scanned, skip to the next part. Use
- * roundown (not roundup), as the loop will increase
- * offset in next step.
- */
- offset = rounddown(offset + trx->length, blocksize);
+ /* Jump to the end of TRX */
+ offset = roundup(offset + trx->length, blocksize);
+ /* Next loop iteration will increase the offset */
+ offset -= blocksize;
continue;
}

--
2.10.1

2016-11-22 19:45:41

by Brian Norris

Subject: Re: [PATCH] mtd: bcm47xxpart: fix parsing first block after aligned TRX

On Sun, Nov 20, 2016 at 04:09:30PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <[email protected]>
>
> After parsing TRX we should skip to the first block placed behind it.
> Our code was working only with TRX with length not aligned to the
> blocksize. In other cases (length aligned) it was missing the block
> places right after TRX.
>
> This fixes calculation and simplifies the comment.
>
> Signed-off-by: Rafał Miłecki <[email protected]>

Applied to l2-mtd.git