2016-11-25 20:31:36

by Dawid Kurek

Subject: [PATCH] staging: gdm724x: Align parameters to parenthesis

Align parameters to open parenthesis. Also remove one blank line in
sequence of two.

Signed-off-by: Dawid Kurek <[email protected]>
---
drivers/staging/gdm724x/gdm_lte.h | 14 +++++++-------
drivers/staging/gdm724x/gdm_tty.h | 1 -
drivers/staging/gdm724x/netlink_k.h | 3 ++-
3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h
index 88414e5..7ddeabc 100644
--- a/drivers/staging/gdm724x/gdm_lte.h
+++ b/drivers/staging/gdm724x/gdm_lte.h
@@ -47,15 +47,15 @@ struct phy_dev {
void *priv_dev;
struct net_device *dev[MAX_NIC_TYPE];
int (*send_hci_func)(void *priv_dev, void *data, int len,
- void (*cb)(void *cb_data), void *cb_data);
+ void (*cb)(void *cb_data), void *cb_data);
int (*send_sdu_func)(void *priv_dev, void *data, int len,
- unsigned int dftEpsId, unsigned int epsId,
- void (*cb)(void *cb_data), void *cb_data,
- int dev_idx, int nic_type);
+ unsigned int dftEpsId, unsigned int epsId,
+ void (*cb)(void *cb_data), void *cb_data,
+ int dev_idx, int nic_type);
int (*rcv_func)(void *priv_dev,
- int (*cb)(void *cb_data, void *data, int len,
- int context),
- void *cb_data, int context);
+ int (*cb)(void *cb_data, void *data, int len,
+ int context),
+ void *cb_data, int context);
struct gdm_endian * (*get_endian)(void *priv_dev);
};

diff --git a/drivers/staging/gdm724x/gdm_tty.h b/drivers/staging/gdm724x/gdm_tty.h
index 297438b..195c590 100644
--- a/drivers/staging/gdm724x/gdm_tty.h
+++ b/drivers/staging/gdm724x/gdm_tty.h
@@ -17,7 +17,6 @@
#include <linux/types.h>
#include <linux/tty.h>

-
#define TTY_MAX_COUNT 2

#define MAX_ISSUE_NUM 3
diff --git a/drivers/staging/gdm724x/netlink_k.h b/drivers/staging/gdm724x/netlink_k.h
index 7cf979b..5ebd731 100644
--- a/drivers/staging/gdm724x/netlink_k.h
+++ b/drivers/staging/gdm724x/netlink_k.h
@@ -18,7 +18,8 @@
#include <net/sock.h>

struct sock *netlink_init(int unit,
- void (*cb)(struct net_device *dev, u16 type, void *msg, int len));
+ void (*cb)(struct net_device *dev,
+ u16 type, void *msg, int len));
int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len);

#endif /* _NETLINK_K_H_ */
--
2.10.0


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

2016-11-26 08:26:20

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: gdm724x: Align parameters to parenthesis

On Fri, Nov 25, 2016 at 09:31:19PM +0100, Dawid Kurek wrote:
> Align parameters to open parenthesis. Also remove one blank line in
> sequence of two.

That's multiple things in the same patch, please break it up into
different patches (hint, if you say "Also" or "And" in a changelog
comment, that's a huge flag that it needs to be split.)

thanks,

greg k-h