2016-11-26 18:30:08

by Borislav Petkov

Subject: [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning

From: Borislav Petkov <[email protected]>

Fix:

drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
static int vmd_suspend(struct device *dev)
^
drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
static int vmd_resume(struct device *dev)
^

Signed-off-by: Borislav Petkov <[email protected]>
Cc: Keith Busch <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Cc: [email protected]
---
drivers/pci/host/vmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
index 37e29b580be3..0e7f8f319fe3 100644
--- a/drivers/pci/host/vmd.c
+++ b/drivers/pci/host/vmd.c
@@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
irq_domain_remove(vmd->irq_domain);
}

-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
static int vmd_suspend(struct device *dev)
{
struct pci_dev *pdev = to_pci_dev(dev);
--
2.10.0

2016-11-28 16:20:54

by Keith Busch

Subject: Re: [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning

On Sat, Nov 26, 2016 at 07:29:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <[email protected]>
>
> Fix:
>
> drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
> static int vmd_suspend(struct device *dev)
> ^
> drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
> static int vmd_resume(struct device *dev)
> ^
>
> Signed-off-by: Borislav Petkov <[email protected]>

Thanks for the fix.

Reviewed-by: Keith Busch <[email protected]>

2016-12-07 18:17:58

by Bjorn Helgaas

Subject: Re: [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning

On Sat, Nov 26, 2016 at 07:29:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <[email protected]>
>
> Fix:
>
> drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
> static int vmd_suspend(struct device *dev)
> ^
> drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
> static int vmd_resume(struct device *dev)
> ^
>
> Signed-off-by: Borislav Petkov <[email protected]>
> Cc: Keith Busch <[email protected]>
> Cc: Bjorn Helgaas <[email protected]>
> Cc: [email protected]

Applied with Keith's reviewed-by to pci/host-vmd for v4.10, thanks!

> ---
> drivers/pci/host/vmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index 37e29b580be3..0e7f8f319fe3 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
> irq_domain_remove(vmd->irq_domain);
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int vmd_suspend(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
> --
> 2.10.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html