2016-11-26 22:22:47

by Peter Foley

Subject: [PATCH] Annotate die() with noreturn

Fixes below warning with clang:

In file included from ../arch/x86/tools/relocs_64.c:17: ../arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (!use_real_mode)
^~~~~~~~~~~~~~ ../arch/x86/tools/relocs.c:989:14: note: uninitialized use occurs here walk_relocs(do_reloc); ^~~~~~~~ ../arch/x86/tools/relocs.c:977:2: note: remove the 'if' if its condition is always true
if (!use_real_mode)
^~~~~~~~~~~~~~~~~~~
../arch/x86/tools/relocs.c:974:24: note: initialize the variable 'do_reloc' to silence this warning
const char *symname);
^
= NULL

Signed-off-by: Peter Foley <[email protected]>
---
arch/x86/tools/relocs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/tools/relocs.h b/arch/x86/tools/relocs.h
index f59590645b68..1d23bf953a4a 100644
--- a/arch/x86/tools/relocs.h
+++ b/arch/x86/tools/relocs.h
@@ -16,7 +16,7 @@
#include <regex.h>
#include <tools/le_byteshift.h>

-void die(char *fmt, ...);
+void die(char *fmt, ...) __attribute__((noreturn));

#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

--
2.11.0.rc2

2016-11-28 07:22:58

by tip-bot for Vasyl Gomonovych

Subject: [tip:x86/urgent] x86/build: Annotate die() with noreturn to fix build warning on clang

Commit-ID: adee8705d2517f0e163ffc45e8d7f9e97a58f1f6
Gitweb: http://git.kernel.org/tip/adee8705d2517f0e163ffc45e8d7f9e97a58f1f6
Author: Peter Foley <[email protected]>
AuthorDate: Sat, 26 Nov 2016 17:22:29 -0500
Committer: Ingo Molnar <[email protected]>
CommitDate: Mon, 28 Nov 2016 07:47:22 +0100

x86/build: Annotate die() with noreturn to fix build warning on clang

Fixes below warning with clang:

In file included from ../arch/x86/tools/relocs_64.c:17:
../arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Signed-off-by: Peter Foley <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/tools/relocs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/tools/relocs.h b/arch/x86/tools/relocs.h
index f595906..1d23bf9 100644
--- a/arch/x86/tools/relocs.h
+++ b/arch/x86/tools/relocs.h
@@ -16,7 +16,7 @@
#include <regex.h>
#include <tools/le_byteshift.h>

-void die(char *fmt, ...);
+void die(char *fmt, ...) __attribute__((noreturn));

#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))