2016-11-28 11:46:11

by Colin King

[permalink] [raw]
Subject: [PATCH net-next] bpf: selftests: include <sys/resource.h> to fix build error

From: Colin Ian King <[email protected]>

Fix incomplete type build error on struct rlimit by including
<sys/resource.h>, fixes:

test_lru_map.c:552:9: error: variable ‘r’ has initializer
but incomplete type
struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
^
test_lru_map.c:552:21: error: ‘RLIM_INFINITY’ undeclared
(first use in this function)
struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};

Signed-off-by: Colin Ian King <[email protected]>
---
tools/testing/selftests/bpf/test_lru_map.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/test_lru_map.c b/tools/testing/selftests/bpf/test_lru_map.c
index 627757e..fde54a2 100644
--- a/tools/testing/selftests/bpf/test_lru_map.c
+++ b/tools/testing/selftests/bpf/test_lru_map.c
@@ -13,6 +13,7 @@
#include <assert.h>
#include <sched.h>
#include <sys/wait.h>
+#include <sys/resource.h>
#include <stdlib.h>
#include <time.h>
#include "bpf_sys.h"
--
2.10.2


2016-11-28 12:22:34

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH net-next] bpf: selftests: include <sys/resource.h> to fix build error

On 11/28/2016 12:45 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Fix incomplete type build error on struct rlimit by including
> <sys/resource.h>, fixes:
>
> test_lru_map.c:552:9: error: variable ‘r’ has initializer
> but incomplete type
> struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
> ^
> test_lru_map.c:552:21: error: ‘RLIM_INFINITY’ undeclared
> (first use in this function)
> struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks for the patch, fixed here already:

https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=e00c7b216f34444252f3771f7d4ed48d4f032636