2016-12-02 14:22:07

by Jesper Nilsson

Subject: [PATCH] net: phy: dp83848: Support ethernet pause frames

According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.

Signed-off-by: Jesper Nilsson <[email protected]>
---
drivers/net/phy/dp83848.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..6e4117f 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c
@@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
.phy_id = _id, \
.phy_id_mask = 0xfffffff0, \
.name = _name, \
- .features = PHY_BASIC_FEATURES, \
+ .features = (PHY_BASIC_FEATURES | \
+ SUPPORTED_Pause | SUPPORTED_Asym_Pause),\
.flags = PHY_HAS_INTERRUPT, \
\
.soft_reset = genphy_soft_reset, \
--
2.1.4


/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

2016-12-02 14:37:08

by Andrew Davis

Subject: Re: [PATCH] net: phy: dp83848: Support ethernet pause frames

On 12/02/2016 08:22 AM, Jesper Nilsson wrote:
> According to the documentation, the PHYs supported by this driver
> can also support pause frames. Announce this to be so.
> Tested with a TI83822I.
>

Looks like all PHYs supported by this driver do, so:

Acked-by: Andrew F. Davis <[email protected]>

> Signed-off-by: Jesper Nilsson <[email protected]>
> ---
> drivers/net/phy/dp83848.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
> index 800b39f..6e4117f 100644
> --- a/drivers/net/phy/dp83848.c
> +++ b/drivers/net/phy/dp83848.c
> @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
> .phy_id = _id, \
> .phy_id_mask = 0xfffffff0, \
> .name = _name, \
> - .features = PHY_BASIC_FEATURES, \
> + .features = (PHY_BASIC_FEATURES | \
> + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\

Aligning these may look nicer though.

> .flags = PHY_HAS_INTERRUPT, \
> \
> .soft_reset = genphy_soft_reset, \
>

2016-12-02 14:52:46

by Jesper Nilsson

Subject: Re: [PATCH] net: phy: dp83848: Support ethernet pause frames

On Fri, Dec 02, 2016 at 08:35:23AM -0600, Andrew F. Davis wrote:
> On 12/02/2016 08:22 AM, Jesper Nilsson wrote:
> > According to the documentation, the PHYs supported by this driver
> > can also support pause frames. Announce this to be so.
> > Tested with a TI83822I.
> >
>
> Looks like all PHYs supported by this driver do, so:
>
> Acked-by: Andrew F. Davis <[email protected]>
>
> > Signed-off-by: Jesper Nilsson <[email protected]>
> > ---
> > drivers/net/phy/dp83848.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
> > index 800b39f..6e4117f 100644
> > --- a/drivers/net/phy/dp83848.c
> > +++ b/drivers/net/phy/dp83848.c
> > @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
> > .phy_id = _id, \
> > .phy_id_mask = 0xfffffff0, \
> > .name = _name, \
> > - .features = PHY_BASIC_FEATURES, \
> > + .features = (PHY_BASIC_FEATURES | \
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\
>
> Aligning these may look nicer though.

Agreed, will send a v2.

> > .flags = PHY_HAS_INTERRUPT, \
> > \
> > .soft_reset = genphy_soft_reset, \
> >

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

2016-12-02 14:57:53

by Jesper Nilsson

Subject: [PATCH v2] net: phy: dp83848: Support ethernet pause frames

According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.

Acked-by: Andrew F. Davis <[email protected]>
Signed-off-by: Jesper Nilsson <[email protected]>
---
drivers/net/phy/dp83848.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..320d0dc 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c
@@ -88,7 +88,9 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
.phy_id = _id, \
.phy_id_mask = 0xfffffff0, \
.name = _name, \
- .features = PHY_BASIC_FEATURES, \
+ .features = (PHY_BASIC_FEATURES | \
+ SUPPORTED_Pause | \
+ SUPPORTED_Asym_Pause), \
.flags = PHY_HAS_INTERRUPT, \
\
.soft_reset = genphy_soft_reset, \
--
2.1.4


/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

2016-12-05 18:14:15

by David Miller

Subject: Re: [PATCH v2] net: phy: dp83848: Support ethernet pause frames

From: Jesper Nilsson <[email protected]>
Date: Fri, 2 Dec 2016 15:57:49 +0100

> According to the documentation, the PHYs supported by this driver
> can also support pause frames. Announce this to be so.
> Tested with a TI83822I.
>
> Acked-by: Andrew F. Davis <[email protected]>
> Signed-off-by: Jesper Nilsson <[email protected]>

Applied to net-next, thanks.